{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":21982089,"defaultBranch":"master","name":"rust-bitcoin","ownerLogin":"rust-bitcoin","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-07-18T13:58:05.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/37084147?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714999742.0","currentOid":""},"activityList":{"items":[{"before":"cc2a31fa60ba581d298ca8dcecb0c49bcd69ada4","after":"8e1e57aba0ec9be75e31a4416a06e98739c2d110","ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-09T01:19:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Automated update to Github CI to rustc nightly-2024-05-08","shortMessageHtmlLink":"Automated update to Github CI to rustc nightly-2024-05-08"}},{"before":"16261c7c772588f7b199bb5294722975a12b08b0","after":"594eb18728fb8a433b1045f7e9c9c507ec54349b","ref":"refs/heads/master","pushedAt":"2024-05-07T14:16:19.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2707: Default to forward for tagged hashes\n\n7685461e62beab0bcec8a96b732e58345b2640d9 Document the sha256t_hash_newtype direction (Tobin C. Harding)\n30e91cc766b6b1523bb8e4c93dbe74a45c097053 Default to forward for tagged hashes (Tobin C. Harding)\n5ecc69cd28b7cd3fc34ce0d52622f3e177a3bb02 Add forward/backward unit test (Tobin C. Harding)\n9aee65d1baf624978c2e767b059a800cc19681b5 Refactor tagged hash tests (Tobin C. Harding)\n216422dffcc7736548d37e3449ef76da1431aa6d Remove schemars impl for test type (Tobin C. Harding)\n\nPull request description:\n\n  First three patches are preparation, improvements to the units tests in `sha256t`.\n\n  From the final patch:\n\n      Displaying backward is an anomaly of Bitcoin Core's early days and the\n      double SHA256 hash type. We should not let this unfortunate beast leak\n      out into other places.\n\n      Default to displaying forward when creating a new tagged hash and remove\n      all the explicit attributes from `bitcoin` that just clutter the code.\n\n  This is an API break and may quietly break some users downstream - eventually we should stop doing that sort of thing.\n\nACKs for top commit:\n  apoelstra:\n    ACK 7685461e62beab0bcec8a96b732e58345b2640d9\n\nTree-SHA512: cb8a41b207aa68ecf63cb7af7f39f7d7c8a3a27f38595867949b288a81a20bff0c17aa4c17bb099e2ecf85194d83bad23c9c9792f511b6c4cd625ff27c1affaa","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2257841044\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2707\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2707/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2707\">#2707</a>: Default to forward for tagged hashes"}},{"before":"1d98472f6f112e9a5b0dbca17b5627c771220bf2","after":"16261c7c772588f7b199bb5294722975a12b08b0","ref":"refs/heads/master","pushedAt":"2024-05-06T17:46:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2746: hashes: Modify trait bounds\n\nd094350230757afb3f0bf93cf49ea2a051153090 hashes: Modify trait bounds (Tobin C. Harding)\n\nPull request description:\n\n  Currently we require indexing trait bounds as well as `Borrow` on the `Hash` trait. We also already implement `AsRef`.\n\n  It was observed that `Borrow<[u8]>` does not best describe what we want from the `Hash` trait implementor but rather `AsRef<[u8]>` does.\n\n  Remove all the inexing trait bounds. Remove the `borrow::Borrow<[u8]>` trait bound. Add a `convert::AsRef<[u8]>` trait bound.\n\n  This leaves the `Borrow<[u8]>` implementation for hashes created with `hash_newtype`, I'm not sure if this should be removed or not.\n\nACKs for top commit:\n  apoelstra:\n    ACK d094350230757afb3f0bf93cf49ea2a051153090 thanks! FWIW I think we might want to return the indexing traits one day, at least `[..]`, but we can do that post-1.0 and we have not gotten any complaints after removing them from the non-HMAC hashes, so maybe people are good with it as is.\n\nTree-SHA512: 2704a7e850083e4eae5844c401c6ac6fe32e0939bbe6e0fb5e21faf4745f9c98634e210f522199ceacd663be60685d7f30df6c89a7787ca11ea8294d104d813e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279964218\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2746\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2746/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2746\">#2746</a>: hashes: Modify trait bounds"}},{"before":"4ef4cfc397db9e81765992c0c542f6089c78eaa8","after":"880cca1f229ed43517c4fd50c1b897191b16a090","ref":"refs/heads/2024-05--disable-cfg-lint","pushedAt":"2024-05-06T17:43:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"add `#![allow(unexpected_cfgs]` to every non-example target\n\nAs of Rust 1.80/nightly 2024-05-05, using custom `cfg` attributes\nrequires that we add a build.rs to all our crates. Aside from slowing\nbuilds, this is a red flag for people trying to audit our crates because\nprior to this change, there was no reason for a project to have a\nbuild.rs except to interact with some other language -- which itself is\nsomething that requires greater scrutiny than a normal Rust crate.\n\nObviously we are not going to do that for any of our crates except for\nrust-secp, which wraps a C library.\n\nWe use custom cfg attributes to allow disabling our cryptography for\ncertain kinds of fuzztests. The Rust blog suggests using Cargo features\nfor this. This is even more insane, because it would then mean that if\n*any dependency* in a user's tree were to enable a \"disable all the\ncrypto\" feature in our projects, the user would be fatally and\nthoroughly compromised.\n\nNo doubt there will be a ton of pushback over the coming weeks but\nbluntly, the Rust community is a dumpster fire and I have zero interest\nin participating in this shit. There is an easy way to just disable the\nnew behavior so do that.","shortMessageHtmlLink":"add <code>#![allow(unexpected_cfgs]</code> to every non-example target"}},{"before":"301e9f92e5f06d958719f5b81d576ceee4f00e42","after":"4ef4cfc397db9e81765992c0c542f6089c78eaa8","ref":"refs/heads/2024-05--disable-cfg-lint","pushedAt":"2024-05-06T14:05:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"add `#![allow(unexpected_cfgs]` to every non-example target\n\nAs of Rust 1.80/nightly 2024-05-05, using custom `cfg` attributes\nrequires that we add a build.rs to all our crates. Aside from slowing\nbuilds, this is a red flag for people trying to audit our crates because\nprior to this change, there was no reason for a project to have a\nbuild.rs except to interact with some other language -- which itself is\nsomething that requires greater scrutiny than a normal Rust crate.\n\nObviously we are not going to do that for any of our crates except for\nrust-secp, which wraps a C library.\n\nWe use custom cfg attributes to allow disabling our cryptography for\ncertain kinds of fuzztests. The Rust blog suggests using Cargo features\nfor this. This is even more insane, because it would then mean that if\n*any dependency* in a user's tree were to enable a \"disable all the\ncrypto\" feature in our projects, the user would be fatally and\nthoroughly compromised.\n\nNo doubt there will be a ton of pushback over the coming weeks but\nbluntly, the Rust community is a dumpster fire and I have zero interest\nin participating in this shit. There is an easy way to just disable the\nnew behavior so do that.","shortMessageHtmlLink":"add <code>#![allow(unexpected_cfgs]</code> to every non-example target"}},{"before":null,"after":"301e9f92e5f06d958719f5b81d576ceee4f00e42","ref":"refs/heads/2024-05--disable-cfg-lint","pushedAt":"2024-05-06T12:49:02.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"add `#![allow(unexpected_cfgs]` to every non-example target\n\nAs of Rust 1.80/nightly 2024-05-05, using custom `cfg` attributes\nrequires that we add a build.rs to all our crates. Aside from slowing\nbuilds, this is a red flag for people trying to audit our crates because\nprior to this change, there was no reason for a project to have a\nbuild.rs except to interact with some other language -- which itself is\nsomething that requires greater scrutiny than a normal Rust crate.\n\nObviously we are not going to do that for any of our crates except for\nrust-secp, which wraps a C library.\n\nWe use custom cfg attributes to allow disabling our cryptography for\ncertain kinds of fuzztests. The Rust blog suggests using Cargo features\nfor this. This is even more insane, because it would then mean that if\n*any dependency* in a user's tree were to enable a \"disable all the\ncrypto\" feature in our projects, the user would be fatally and\nthoroughly compromised.\n\nNo doubt there will be a ton of pushback over the coming weeks but\nbluntly, the Rust community is a dumpster fire and I have zero interest\nin participating in this shit. There is an easy way to just disable the\nnew behavior so do that.","shortMessageHtmlLink":"add <code>#![allow(unexpected_cfgs]</code> to every non-example target"}},{"before":"2e8bd5f06a40aba7e949ee547e9f0b1e9fbe65db","after":"1d98472f6f112e9a5b0dbca17b5627c771220bf2","ref":"refs/heads/master","pushedAt":"2024-05-06T12:43:03.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2744: CI: Update nightly semi-weekly\n\ncf19e37785d555cf2455c207425bad0cca435338 CI: Update nightly semi-weekly (Tobin C. Harding)\n\nPull request description:\n\n  Updating the nightly toolchain every day is overly arduous, lets just update it twice a week.\n\nACKs for top commit:\n  apoelstra:\n    ACK cf19e37785d555cf2455c207425bad0cca435338 CI-only, will one-ACK merge\n\nTree-SHA512: c827a1805efea43b945c254775cde7d3e064ccebbcca7cf0d9ca92447e54a43ec0f41d324b3e39d70ff060620ef005e867578461d1eb4b69996d2416f69f6a05","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279785210\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2744\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2744/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2744\">#2744</a>: CI: Update nightly semi-weekly"}},{"before":"b705ac62e63ac447c674f88a1e6e208af211ba51","after":"cc2a31fa60ba581d298ca8dcecb0c49bcd69ada4","ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-06T01:07:56.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Automated update to Github CI to rustc nightly-2024-05-05","shortMessageHtmlLink":"Automated update to Github CI to rustc nightly-2024-05-05"}},{"before":"9af391c90eda991ba8b23b727588b7b73b41fc47","after":"2e8bd5f06a40aba7e949ee547e9f0b1e9fbe65db","ref":"refs/heads/master","pushedAt":"2024-05-06T00:06:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"tcharding","name":"Tobin C. Harding","path":"/tcharding","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12626037?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2743: Automated daily update to rustc (to nightly-2024-05-04)\n\nb705ac62e63ac447c674f88a1e6e208af211ba51 Automated update to Github CI to rustc nightly-2024-05-04 (Update Nightly Rustc Bot)\n\nPull request description:\n\n  Automated update to Github CI workflow `rust.yml` by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action\n\nACKs for top commit:\n  tcharding:\n    ACK b705ac62e63ac447c674f88a1e6e208af211ba51\n\nTree-SHA512: e43188c0ba5d5b38c7bdb192e5ade7f612e1867bb9825676412237200b54d4d4417c4f306339b745e1af08907d9f8a377bddabe52e6bce8af0925149506e6fa5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279267384\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2743\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2743/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2743\">#2743</a>: Automated daily update to rustc (to nightly-2024-05-04)"}},{"before":"23c0537f2dca6484f72d5160ec297445723da7f6","after":"9af391c90eda991ba8b23b727588b7b73b41fc47","ref":"refs/heads/master","pushedAt":"2024-05-05T22:04:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2742: Automated nightly rustfmt (2024-05-05)\n\n93300a42ed9f537867e965160a184a64f039718b 2024-05-05 automated rustfmt nightly (Fmt Bot)\n\nPull request description:\n\n  Automated nightly `rustfmt` changes by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action\n\nACKs for top commit:\n  apoelstra:\n    ACK 93300a42ed9f537867e965160a184a64f039718b\n\nTree-SHA512: bedddcf52a7746086e7cd9fb4b05c9c1743da73658e156919ff6ab4c69d51368f5aef6cacbbf839b442f752a47e89c01a9362865a32405e274d784eac5032d71","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2279265874\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2742\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2742/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2742\">#2742</a>: Automated nightly rustfmt (2024-05-05)"}},{"before":null,"after":"b705ac62e63ac447c674f88a1e6e208af211ba51","ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-05T01:10:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Automated update to Github CI to rustc nightly-2024-05-04","shortMessageHtmlLink":"Automated update to Github CI to rustc nightly-2024-05-04"}},{"before":null,"after":"93300a42ed9f537867e965160a184a64f039718b","ref":"refs/heads/create-pull-request/patch","pushedAt":"2024-05-05T01:04:08.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"2024-05-05 automated rustfmt nightly","shortMessageHtmlLink":"2024-05-05 automated rustfmt nightly"}},{"before":"0a5d8b07a89a740d8a8b05edafcbe94e8508649c","after":null,"ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-04T22:05:00.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"}},{"before":"343c770ee701b96815b5c4eee16a11a3eef60526","after":"23c0537f2dca6484f72d5160ec297445723da7f6","ref":"refs/heads/master","pushedAt":"2024-05-04T21:50:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"tcharding","name":"Tobin C. Harding","path":"/tcharding","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12626037?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2741: Automated daily update to rustc (to nightly-2024-05-03)\n\n0a5d8b07a89a740d8a8b05edafcbe94e8508649c Automated update to Github CI to rustc nightly-2024-05-03 (Update Nightly Rustc Bot)\n\nPull request description:\n\n  Automated update to Github CI workflow `rust.yml` by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action\n\nACKs for top commit:\n  tcharding:\n    ACK 0a5d8b07a89a740d8a8b05edafcbe94e8508649c\n\nTree-SHA512: 98d9cfb0cffe94b78a5939e0967d73f3c5ab382527dd66bc4f4823d8327d1afe6bb2d779c467ed9e815bcf25d7ca7940d9799c189b355cc642db000e633ceb1f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2278638091\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2741\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2741/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2741\">#2741</a>: Automated daily update to rustc (to nightly-2024-05-03)"}},{"before":"4b6b55f0cd757690c0a815bd0b79d6c7d9508be1","after":"e376e9056dff4cd20cfae54442d4cc2838f74b42","ref":"refs/heads/0.30.x","pushedAt":"2024-05-04T12:39:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2620: bitcoin: Depend on and export hex-conservative\n\n8273b807fe1e445b95a52e29d0ff83f230afc14d bitcoin: Depend on and export hex-conservative (Tobin C. Harding)\n\nPull request description:\n\n  When we did the `rust-bitcoin v0.30.0` release we had not yet released the `hex-conservative` crate so we forced users to reach into `bitcoin-internals` to get at hex stuff e.g., `DisplayHex`.\n\n  To ease the upgrade path for any remaining upgraders add a dependency on the now released `hex-conservative` crate and re-export it from the crate root as `hex` (bit late I know, sorry).\n\n  Idea came from: https://github.com/rust-bitcoin/rust-bitcoin/issues/2482#issuecomment-1947075032\n\n  We should have done this soon as we released `hex-conservative`.\n\nACKs for top commit:\n  apoelstra:\n    utACK 8273b807fe1e445b95a52e29d0ff83f230afc14d -- tested `cargo test` at least\n\nTree-SHA512: 6c2cd137f9e5d00fb2ecfb35ce368b4555ece81a360e02770090870dd79f8fa8cf22f600399a9311bddeb433e752d387bef1dd5721cf0823bced5895e17e662e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2198711688\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2620\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2620/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2620\">#2620</a>: bitcoin: Depend on and export hex-conservative"}},{"before":"ecfe5565472e5499dd8d0362b41f192367e6368a","after":"343c770ee701b96815b5c4eee16a11a3eef60526","ref":"refs/heads/master","pushedAt":"2024-05-04T11:54:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2662: hashes: Do not import str\n\n71bb86232bc8b21ba746ca5bbab0acd96cb85b46 hashes: Do not import str (Tobin C. Harding)\n\nPull request description:\n\n  Depending on things being in scope for macros to use is bad form, using the fully qualified path is the correct way.\n\n  Do not import `str` instead use the fully qualified path to the `core` re-export.\n\n  Use fully qualified path instead.\n\nACKs for top commit:\n  apoelstra:\n    ACK 71bb86232bc8b21ba746ca5bbab0acd96cb85b46 trivial rebase\n  sanket1729:\n    ACK 71bb86232bc8b21ba746ca5bbab0acd96cb85b46\n\nTree-SHA512: 401520a5876b83ad4053bbe9b1e8cd9ff2e723cf86f95e47891a6411ad5e9af4f904e19ccaaab80d342dfe4745753c24af168dcbc8170fb6b39da08e577d30ae","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2226784195\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2662\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2662/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2662\">#2662</a>: hashes: Do not import str"}},{"before":null,"after":"0a5d8b07a89a740d8a8b05edafcbe94e8508649c","ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-04T01:05:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Automated update to Github CI to rustc nightly-2024-05-03","shortMessageHtmlLink":"Automated update to Github CI to rustc nightly-2024-05-03"}},{"before":"541877472f8c627e094329b567de21dddb7dfa94","after":"ecfe5565472e5499dd8d0362b41f192367e6368a","ref":"refs/heads/master","pushedAt":"2024-05-03T13:46:55.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2679: just: Add just fmt\n\ne565e06b0c84c81a5b8c7d46a795f8f218dfb9f8 just: Add just fmt (Tobin C. Harding)\n\nPull request description:\n\n  We already have a `just` command to check the formatting, add one to run the formatter. Use the more terse `just fmt` although the difference from `just format` is not super obvious it is documented in the default output of `just`.\n\n  With this applied we have\n  ```bash\n  $ just\n  Available recipes:\n      build             # Cargo build everything.\n      check             # Cargo check everything.\n      default\n      fmt               # Run cargo fmt\n      format            # Check the formatting\n      lint              # Lint everything.\n      sane              # Quick and dirty CI useful for pre-push checks.\n      update-lock-files # Update the recent and minimal lock files.\n  ```\n\nACKs for top commit:\n  apoelstra:\n    ACK e565e06b0c84c81a5b8c7d46a795f8f218dfb9f8\n\nTree-SHA512: 0e73bad93708f626bd00eabc4e2264f2f2fddb0d8cb80a4464889f14077b29ecabdf1865c9dbe3ca7b08354585e3579c515dedcd2b05f34ae863aab31382de33","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2236757414\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2679\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2679/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2679\">#2679</a>: just: Add just fmt"}},{"before":"69f799acc54eb4255d0dc8c896f55687b974642c","after":null,"ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-03T13:27:17.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"}},{"before":"97153516debd41eb2fb0cc630fc904768eb68686","after":"541877472f8c627e094329b567de21dddb7dfa94","ref":"refs/heads/master","pushedAt":"2024-05-03T02:39:34.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"tcharding","name":"Tobin C. Harding","path":"/tcharding","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12626037?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2735: Automated daily update to rustc (to nightly-2024-05-02)\n\n69f799acc54eb4255d0dc8c896f55687b974642c Automated update to Github CI to rustc nightly-2024-05-02 (Update Nightly Rustc Bot)\n\nPull request description:\n\n  Automated update to Github CI workflow `rust.yml` by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action\n\nACKs for top commit:\n  tcharding:\n    ACK 69f799acc54eb4255d0dc8c896f55687b974642c\n\nTree-SHA512: 0c2bedf09668db55e2dde1f5add6a53478c9479451b5d91cf95ebeaac9159840bd6d484af93af15f6035997831500c785abd227bfcbbd4cc0ff1ea292d163b96","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2274417019\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2735\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2735/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2735\">#2735</a>: Automated daily update to rustc (to nightly-2024-05-02)"}},{"before":"deebfc569645008b4178d54b1b2ad471930882d4","after":"69f799acc54eb4255d0dc8c896f55687b974642c","ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-03T01:09:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Automated update to Github CI to rustc nightly-2024-05-02","shortMessageHtmlLink":"Automated update to Github CI to rustc nightly-2024-05-02"}},{"before":"587b4fee47e8b976da857dcb77e59e6e95af2d3a","after":"97153516debd41eb2fb0cc630fc904768eb68686","ref":"refs/heads/master","pushedAt":"2024-05-02T13:26:44.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2737: fuzz: Update generate-files.sh\n\nc750be23520d24c930fa3d7bebed7232aaa6b5cd fuzz: Update generate-files.sh (Tobin C. Harding)\n\nPull request description:\n\n  Recently we modified the fuzz job manually and forgot about the `generate-files.sh` file.\n\n  Update the script to match the current CI job, running it now produces the same file `cron-daily-fuzz.sh`.\n\nACKs for top commit:\n  storopoli:\n    ACK c750be23520d24c930fa3d7bebed7232aaa6b5cd\n  apoelstra:\n    ACK c750be23520d24c930fa3d7bebed7232aaa6b5cd\n\nTree-SHA512: 13ec222f760848d2089fd0e92460f18548c11b1dd2025ca804567eadd52e040c90c668126e63ce794023034e5606772cbe3293eae49327f0934c45cd1b7baf47","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2274681048\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2737\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2737/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2737\">#2737</a>: fuzz: Update generate-files.sh"}},{"before":"ad212da9305a257f236746511edf707f42334361","after":"587b4fee47e8b976da857dcb77e59e6e95af2d3a","ref":"refs/heads/master","pushedAt":"2024-05-02T12:45:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2734: fix(typo): examples/ecdsa-psbt.rs\n\nf0093c0f1c46b300281ab8b4db2c4f755fd0d8f3 fix(typo): examples/ecdsa-psbt.rs (Jose Storopoli)\n\nPull request description:\n\n  \"Creater\" is a typo, it should be \"Creator\" role.\n\n  Ref: https://github.com/bitcoin/bips/blob/master/bip-0174.mediawiki?plain=1#L660\n\nACKs for top commit:\n  tcharding:\n    ACK f0093c0f1c46b300281ab8b4db2c4f755fd0d8f3\n  apoelstra:\n    ACK f0093c0f1c46b300281ab8b4db2c4f755fd0d8f3\n\nTree-SHA512: ccdae4979da2044b4fdf3a0522e5cb6d64b394baadb6107d5e58096d2741458085c6ef349924bc0aa64eca69b89e394eb16fbf890c86716608ee06d287828ff2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2274189766\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2734\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2734/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2734\">#2734</a>: fix(typo): examples/ecdsa-psbt.rs"}},{"before":null,"after":"deebfc569645008b4178d54b1b2ad471930882d4","ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-02T01:05:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Automated update to Github CI to rustc nightly-2024-05-01","shortMessageHtmlLink":"Automated update to Github CI to rustc nightly-2024-05-01"}},{"before":"bc91bb33cb27d7445298f13c25b76dc4045c05c6","after":"ad212da9305a257f236746511edf707f42334361","ref":"refs/heads/master","pushedAt":"2024-05-01T10:54:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2693: Fix typo in deprecated type\n\n12411fc917abc7fd06b08dd4065286191f892342 Fix typo in deprecated BIP-32 type (matthiasdebernardini)\n\nPull request description:\n\n  In #2258 we attempted to add back in deprecated BIP-32 types - but we spelled the identifier incorrectly. The patch was then backported to the `0.31.x` branch in December but was only just noticed now.\n\n  Fix typo in deprecated type from `Extendend` -> `Extended`.\n\nACKs for top commit:\n  tcharding:\n    ACK 12411fc917abc7fd06b08dd4065286191f892342\n  storopoli:\n    ACK 12411fc917abc7fd06b08dd4065286191f892342\n  apoelstra:\n    ACK 12411fc917abc7fd06b08dd4065286191f892342\n\nTree-SHA512: f70e8fe741740f62b29932d8ee84cbe7803cb71dfb0491d251c3a982ede07ea7a32b5ecdf569d6012ee05509e8182a439b022c606a2f01742f4908089edc85a9","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2248767884\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2693\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2693/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2693\">#2693</a>: Fix typo in deprecated type"}},{"before":"83b517fe70c8fd9a7a0eabce5ac8c214539bf08c","after":null,"ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-01T10:30:40.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"}},{"before":"77992886188311c3423a25e4b0bfc182e3703dc3","after":"bc91bb33cb27d7445298f13c25b76dc4045c05c6","ref":"refs/heads/master","pushedAt":"2024-05-01T01:49:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"tcharding","name":"Tobin C. Harding","path":"/tcharding","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12626037?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2731: Automated daily update to rustc (to nightly-2024-04-30)\n\n83b517fe70c8fd9a7a0eabce5ac8c214539bf08c Automated update to Github CI to rustc nightly-2024-04-30 (Update Nightly Rustc Bot)\n\nPull request description:\n\n  Automated update to Github CI workflow `rust.yml` by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action\n\nACKs for top commit:\n  tcharding:\n    ACK 83b517fe70c8fd9a7a0eabce5ac8c214539bf08c\n\nTree-SHA512: 093b177b391519d5fb5a1ad63984296cd3e7dc49e861735e8ce389eee23c568d981dd45196eb87973adf387deace2c670ac2c86208e92419512934b43e0a3b1b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2272744606\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2731\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2731/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2731\">#2731</a>: Automated daily update to rustc (to nightly-2024-04-30)"}},{"before":null,"after":"83b517fe70c8fd9a7a0eabce5ac8c214539bf08c","ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-05-01T01:10:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Automated update to Github CI to rustc nightly-2024-04-30","shortMessageHtmlLink":"Automated update to Github CI to rustc nightly-2024-04-30"}},{"before":"a552e6bbb719f885eeec51643b70c84b5175fd0f","after":null,"ref":"refs/heads/create-pull-request/daily-nightly-update","pushedAt":"2024-04-30T13:40:52.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"}},{"before":"819eaa95bcfb1527989ed489062eb3113226d2fb","after":"77992886188311c3423a25e4b0bfc182e3703dc3","ref":"refs/heads/master","pushedAt":"2024-04-30T05:00:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"tcharding","name":"Tobin C. Harding","path":"/tcharding","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12626037?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bitcoin#2730: Automated daily update to rustc (to nightly-2024-04-29)\n\na552e6bbb719f885eeec51643b70c84b5175fd0f Automated update to Github CI to rustc nightly-2024-04-29 (Update Nightly Rustc Bot)\n\nPull request description:\n\n  Automated update to Github CI workflow `rust.yml` by [create-pull-request](https://github.com/peter-evans/create-pull-request) GitHub action\n\nACKs for top commit:\n  tcharding:\n    ACK a552e6bbb719f885eeec51643b70c84b5175fd0f\n\nTree-SHA512: 12727e742ea59644f17bbb99e4a84196f0d25d2aa12a79e3a0d87da7fd452944d9073b5acde33e5e2c1445ea5035b757becb43241884497762464e814324078c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2270296156\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bitcoin/issues/2730\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bitcoin/pull/2730/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bitcoin/pull/2730\">#2730</a>: Automated daily update to rustc (to nightly-2024-04-29)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAERSr8gwA","startCursor":null,"endCursor":null}},"title":"Activity · rust-bitcoin/rust-bitcoin"}