Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cookbook): PSBTs multiple inputs #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(cookbook): PSBTs multiple inputs #32

wants to merge 2 commits into from

Conversation

storopoli
Copy link
Contributor

@storopoli storopoli commented May 4, 2024 •
edited

Adds examples on how to create, update, sign, and finalize PSBTs version 0 that deals with multiple inputs.

Examples are SegWit V0 and Taproot.

  • updates CI to capture all nested *.md files
  • PSBT introduction
  • SegWit V0
  • Taproot

Closes #26.

@storopoli storopoli marked this pull request as draft May 4, 2024 09:58
@storopoli storopoli changed the title WIP: feat(cookbook): PSBTs multiple inputs feat(cookbook): PSBTs multiple inputs May 5, 2024
@storopoli storopoli marked this pull request as ready for review May 5, 2024 17:59
@storopoli
Copy link
Contributor Author

Ready to review guys!

storopoli
storopoli commented May 5, 2024
View reviewed changes
cookbook/tests/generate.sh
@@ -7,7 +7,7 @@ cat << EOF > src/lib.rs
extern crate doc_comment;
EOF

for doc in ../src/*.md
for doc in ../src/**/*.md
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new examples are in a nested dir inside src/.
That's why this change

tcharding
tcharding reviewed May 6, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started reviewing but then realised, while struggling with reviewing code in either the markdown file or the rendered HTML, that for the other cookbook stuff I did a PR into rust-bitcoin/bitcoin/examples first.

Any chance you would be willing to do that also, then we can review the code like normal and copying it to the cookbook is just a matter of cut'n'pasting the relevant bits.

cookbook/src/psbt.md Outdated Show resolved Hide resolved
cookbook/src/psbt.md Outdated Show resolved Hide resolved
cookbook/src/psbt.md Outdated Show resolved Hide resolved
@storopoli
Copy link
Contributor Author

Any chance you would be willing to do that also, then we can review the code like normal and copying it to the cookbook is just a matter of cut'n'pasting the relevant bits.

Yes of course!
That was my original idea.
I just thought that since this is a VERY stripped down of
bitcoin/examples/ecdsa-psbt.rs
and bitcoin/examples/taproot-psbt.rs,
that they would not be "worth" of an example in rust-bitcoin.

That's why I PR'd here only and first.
But yeah I'll work on a code + comments version of these in rust-bitcoin.
That's a great suggestion and thanks for encouraging it.

@storopoli storopoli force-pushed the storopoli/sign-psbt branch 8 times, most recently from 28823dd to e2fe60f Compare May 12, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcharding tcharding tcharding left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Cookbook on how to sign multiple inputs.
2 participants
@storopoli @tcharding