Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert HRP to lowercase for encoding purposes #41

Merged
merged 3 commits into from Jan 3, 2020
Merged

Convert HRP to lowercase for encoding purposes #41

merged 3 commits into from Jan 3, 2020

Conversation

clarkmoody
Copy link
Member

Fixes #40

@clarkmoody clarkmoody marked this pull request as ready for review December 31, 2019 23:45
sgeisler
sgeisler reviewed Jan 1, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
sgeisler
sgeisler suggested changes Jan 1, 2020
View reviewed changes
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general. I'd just like to avoid the extra allocation in the much more likely scenario of getting an already lowercase input.

@clarkmoody clarkmoody mentioned this pull request Jan 3, 2020
Merged
sgeisler
sgeisler approved these changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarkmoody clarkmoody merged commit ccbb003 into master Jan 3, 2020
@clarkmoody clarkmoody deleted the issue-40 branch January 3, 2020 15:39
@clarkmoody clarkmoody mentioned this pull request Jan 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgeisler sgeisler sgeisler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bech32::encode computes incorrect checksum for uppercase HRPs
2 participants
@clarkmoody @sgeisler