{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":90658729,"defaultBranch":"master","name":"rust-bech32","ownerLogin":"rust-bitcoin","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2017-05-08T18:14:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/37084147?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708711813.0","currentOid":""},"activityList":{"items":[{"before":"c2aac494b9932802b99ed648aac34be0822d63e1","after":"cd20221f31b70a48bdfb9467f4c6320a94433358","ref":"refs/heads/master","pushedAt":"2024-03-05T15:15:35.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#179: Fixed error message for too long hrp prefix\n\nc0220d82a33c040a093357e9ccd876005fe00772 Run 'cargo +nightly fmt' on this. Options in rustfmt.toml apply only in nightly channel. (Dariusz Depta)\n930918325a28062beb39581f8d55d6344c8fb6e3 Removed unneeded test. (Dariusz Depta)\nef50d6d1874b625ea35845630e6d73e0001a6aa0 Fixed error message for too long hrp. (Dariusz Depta)\n\nPull request description:\n\n  closes #178\n\nACKs for top commit:\n  apoelstra:\n    ACK c0220d82a33c040a093357e9ccd876005fe00772 though in future, please squash together commits which modify previous commits\n\nTree-SHA512: e876684ad0560c268af695500af0936dd8803598325e61647589c8f5469a8002bb7c18fc547a1a691803ab0d40b8b6e713ae22f1ff63ec56c38af38567f04d98","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2167125020\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/179\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/179/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/179\">#179</a>: Fixed error message for too long hrp prefix"}},{"before":"0541ee45740a389956a672150e0c1b85f5216ea2","after":"c2aac494b9932802b99ed648aac34be0822d63e1","ref":"refs/heads/master","pushedAt":"2024-02-23T18:09:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#177: Bump version to 0.11.0\n\n87a6c11e00b9b01adb215322a1bdc85859301fc8 Bump version to 0.11.0 (Tobin C. Harding)\n\nPull request description:\n\n  We really should have remembered this would happen because of all the drama we had in `bitcoinconsensus`, face palm.\n\n  Bump the verison and add a changelog entry explaining the yank and re-release for those that don't know.\n\nACKs for top commit:\n  apoelstra:\n    ACK 87a6c11e00b9b01adb215322a1bdc85859301fc8 sounds good; will go ahead with this without waiting for Clark since he ACKed the last release\n\nTree-SHA512: 22190d70a12dcaa7875836df0a4cbf6967050cb734f4e418e0cdfb846e2bf73bc5ae2f2431cacddcd0516ce901c4de7ee009ae3e987949c01f2e109a732e58a0","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2150201430\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/177\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/177/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/177\">#177</a>: Bump version to 0.11.0"}},{"before":"ea5385e2efe452a9c5925529daa094aec4ce0e8a","after":"0541ee45740a389956a672150e0c1b85f5216ea2","ref":"refs/heads/master","pushedAt":"2024-02-22T17:36:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#168: Release tracking PR: `v0.10.0`\n\n1b64ed4204e85a8d4907fc92af48e7e1e6eaa79b Bump version to 0.10.0 (Tobin C. Harding)\n\nPull request description:\n\n  In preparation for doing the first \"real\" (non-beta) release of the new `primitives` module add a changelog entry and bump the version.\n\nACKs for top commit:\n  clarkmoody:\n    ACK 1b64ed4204e85a8d4907fc92af48e7e1e6eaa79b\n  apoelstra:\n    ACK 1b64ed4204e85a8d4907fc92af48e7e1e6eaa79b let's do it\n\nTree-SHA512: 8fa1282de38322e683f7352bd1c7e25d22a147e4ec2a7df5ca7359014e76a4ffce528d9b0a40238eac10a6e0a7cfafac1bb2c5b3d4978f05a30450338c089777","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2080892001\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/168\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/168/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/168\">#168</a>: Release tracking PR: <code>v0.10.0</code>"}},{"before":"92146d7bbdacde6bd12fd125fbb673785e884be5","after":"ea5385e2efe452a9c5925529daa094aec4ce0e8a","ref":"refs/heads/master","pushedAt":"2024-02-13T14:29:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#141: Check for changes to the public API\n\n8241316a4c9d02f3c1e35bfb7227808912652b0b Check for public API changes (Tobin C. Harding)\n\nPull request description:\n\n  We would like to get to a stage where we can commit to the public API. To help us achieve this add a script that generates the public API and checks it against three committed files, one for each feature set: no features, alloc, std.\n\n  The idea is that with this applied any PR that changes the public API should include a final patch that is just the changes to the api/*.txt files, that way reviewers can discuss the changes without even needing to look at the code, quickly giving concept ACK/NACKs. We also run the script in CI to make sure we have not accidentally changed the public API so that we can be confident that don't break semver during releases. The script can also be used to diff between two release versions to get a complete list of API changes, useful for writing release notes and for users upgrading.\n\n  There is a development burden involved if we apply this patch.\n\nACKs for top commit:\n  clarkmoody:\n    ACK 8241316a4c9d02f3c1e35bfb7227808912652b0b\n  apoelstra:\n    ACK 8241316a4c9d02f3c1e35bfb7227808912652b0b\n\nTree-SHA512: 22a47e456ecedd7f1019c3f90bafbebf40ed841d24b577c08f456883638b1b49ab2f2c86b0a642e8b425f528b1bf25015642627b3bc3c6c2b19fb3f4b1605939","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1946373385\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/141\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/141/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/141\">#141</a>: Check for changes to the public API"}},{"before":"50d59d66a8510a69c459d251f2391dd6b212fb4b","after":"92146d7bbdacde6bd12fd125fbb673785e884be5","ref":"refs/heads/master","pushedAt":"2024-01-30T16:06:45.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#175: Add witness_version functions to `CheckedHrpstring`\n\n2d7832ac9aad87c67b0c3be99b9af6966cbc168e Add witness_version functions to CheckedHrpstring (Tobin C. Harding)\n3ce7225942800d5e56c9c15804ced7872887ef95 Improve docs on `UncheckedHrpstring::witness_version` (Tobin C. Harding)\n\nPull request description:\n\n  As we did for `UncheckedHrpstring` add functions to the `CheckedHrpstring` struct to allow checking the initial byte of the data part and removing it if required.\n\n  Add an initial patch that improves the docs on the `UncheckedHrpstring::remove_witness_version` function (this is then copied in patch 2).\n\nACKs for top commit:\n  apoelstra:\n    ACK 2d7832ac9aad87c67b0c3be99b9af6966cbc168e tested with rust-elements and it works!\n\nTree-SHA512: e380f524c06f8bfa6efe952e835fef66c3620367ed94d6716c6b5070479188ea95d719958292258938c0a3d709810c2da46af35b910e63e0a630776ce0691fbc","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2104354168\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/175\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/175/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/175\">#175</a>: Add witness_version functions to <code>CheckedHrpstring</code>"}},{"before":"091187ea5bfff650deb3bbb6ab2a2c368e925ab2","after":"50d59d66a8510a69c459d251f2391dd6b212fb4b","ref":"refs/heads/master","pushedAt":"2024-01-30T14:51:18.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#176: Fix feature gating\n\n1f773b9cbfd01078d2822c9cfca77f74a59f6b69 Feature gate the segwit::EncodeError (Tobin C. Harding)\n9aca6a9e714ae3c841074622f73d90e38668bca1 Remove links to feature gated functions (Tobin C. Harding)\n\nPull request description:\n\n  We have feature gate issues in docs and with an unused error type.\n\n  I don't have a good way of including links that are feature build specific in rustdocs so I just used plain old back ticks.\n\nACKs for top commit:\n  apoelstra:\n    ACK 1f773b9cbfd01078d2822c9cfca77f74a59f6b69\n\nTree-SHA512: b2fe813da0c8957b2ce30253ce625e4bb088a56655fc27987d324bb977a6e251ca00fb277cc341b2ba6526b6d4b4b8e0b9dd666068e9c3300e667a349f38f5d7","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2106546944\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/176\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/176/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/176\">#176</a>: Fix feature gating"}},{"before":"e6660be1ae800b36f1642aa654e2632103e5deb9","after":"091187ea5bfff650deb3bbb6ab2a2c368e925ab2","ref":"refs/heads/master","pushedAt":"2024-01-23T16:13:15.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#174: Add `CheckedHrpstring::fe32_iter` function\n\n319d9e335b1dcb4f783a455b3f532e917ca5526c Remove generics from AsciiToFe32Iter (Tobin C. Harding)\n931b80f96f0314c43ac3b06085b30b39eebd3ba9 Add CheckedHrpstring::fe32_iter function (Tobin C. Harding)\n\nPull request description:\n\n  Simplify the `AsciiToFe32Iter`, make it public, and add a function to create it.\n\nACKs for top commit:\n  apoelstra:\n    ACK 319d9e335b1dcb4f783a455b3f532e917ca5526c\n\nTree-SHA512: 5ea007de59dafb59f2b209e4660367306f279c1ceac3dad52744a7298f99d6bc294dabae6c6fa7899f9223c4249e74dd68f54a03131f929812cf2039a820e34c","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2095270078\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/174\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/174/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/174\">#174</a>: Add <code>CheckedHrpstring::fe32_iter</code> function"}},{"before":"de97a8e41b8a151832c6c0acb1298cbcc3e98205","after":"e6660be1ae800b36f1642aa654e2632103e5deb9","ref":"refs/heads/master","pushedAt":"2024-01-23T15:59:34.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#173: Make a couple of the functions on `CheckedHrpstring` struct public\n\nbde1df5c210cfe649ffb7bf47bf7cae49f9bd49e Make validate_witness_program_length public (Tobin C. Harding)\nbdd6855a7b4dc6861af72a4b7d14e423556130ae Make validate_padding public (Tobin C. Harding)\n\nPull request description:\n\n  These two functions are useful to users of the lib, lets make them public.\n\nACKs for top commit:\n  apoelstra:\n    ACK bde1df5c210cfe649ffb7bf47bf7cae49f9bd49e\n\nTree-SHA512: dc59f120a9cee1ae00007e14901feae3127e54d0f9d6f34204fc0909d890a84a3c9357066600f0ca203e21b91825365d32284e5acabde3f662aae25f772e7194","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2095248161\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/173\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/173/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/173\">#173</a>: Make a couple of the functions on <code>CheckedHrpstring</code> stru…"}},{"before":"d9b727b00453009291911f0314fc22bc1c7be251","after":"de97a8e41b8a151832c6c0acb1298cbcc3e98205","ref":"refs/heads/master","pushedAt":"2024-01-23T15:45:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#172: Use correct lifetime\n\n9db843dbddbcdfe84e6e377612586a452cd1baff Use correct lifetime (Tobin C. Harding)\n\nPull request description:\n\n  We are returning an reference to the ascii input string, this has a lifetime associated with it - use it.\n\nACKs for top commit:\n  apoelstra:\n    ACK 9db843dbddbcdfe84e6e377612586a452cd1baff\n\nTree-SHA512: a6fda390ed969e763c82fe194adc7b44dd36f756548a77aaa381ce5d251e5b4ef3215c143c6944b842626ff9b0b679d7aee3daee2bb5c4a82dff49c59dba7a37","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2095247562\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/172\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/172/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/172\">#172</a>: Use correct lifetime"}},{"before":"03bda89c2afde3fd973411c554887a05b6dbab16","after":"d9b727b00453009291911f0314fc22bc1c7be251","ref":"refs/heads/master","pushedAt":"2024-01-17T15:20:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#170: Use 0.10.0-beta.2 for the upcoming release\n\n15dfdf0d086c75a59464cf09ee414b5dd283b6cf Use 0.10.0-beta.2 for the upcoming release (Tobin C. Harding)\n\nPull request description:\n\n  We just bumped the version number to `0.10.0-beta2` but that format causes `cargo` to automatically pull the new version. We can use `0.10.1-beta.2` so `cargo` correctly treats it as a new separate version.\n\nACKs for top commit:\n  apoelstra:\n    ACK 15dfdf0d086c75a59464cf09ee414b5dd283b6cf\n\nTree-SHA512: 5676044d23d981ff8df753f74694425a90e8dc5af9791ca32d3dce405a891d49febae3ed5e455cb770dccaaccd2028e71c63f7bc2737114bd32016f7964edaf6","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2085049499\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/170\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/170/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/170\">#170</a>: Use 0.10.0-beta.2 for the upcoming release"}},{"before":"8ffd138258b4b93237bfe81179170dd73fd1b2b3","after":"03bda89c2afde3fd973411c554887a05b6dbab16","ref":"refs/heads/master","pushedAt":"2024-01-16T15:34:01.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#169: Bump version to 0.10.0-beta2\n\n7dc7f0afc8f4e37af60151a2a0e38612471d244e Bump version to 0.10.0-beta2 (Tobin C. Harding)\n\nPull request description:\n\n  In preparation for doing another beta release add a changelog entry and bump the version.\n\nACKs for top commit:\n  apoelstra:\n    ACK 7dc7f0afc8f4e37af60151a2a0e38612471d244e\n\nTree-SHA512: cba30d4b306875af9c750c1156d2acba5f722cf3c681761fc1cf63b0770bfff893cfa5d3cadde916031169cb462e759c198ed5d74717f69564cd6043b20f827f","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2082643785\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/169\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/169/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/169\">#169</a>: Bump version to 0.10.0-beta2"}},{"before":"cb2f61ede8fcf60192a2d366fccb41ffb4380296","after":"8ffd138258b4b93237bfe81179170dd73fd1b2b3","ref":"refs/heads/master","pushedAt":"2024-01-13T01:08:48.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#134: Do some docs fixes\n\nea97465565cab18601665467a5a27493ec776594 Remove backticks for bip names (Tobin C. Harding)\n8dec93d90ccab9d6595d42f58a2048489318c7ed Drop docs usage of \"higher\" (Tobin C. Harding)\n628093553ba8a68991433a315f640a00dd93bad3 Update \"crate level API\" docs (Tobin C. Harding)\n521d96338cb3f589c622449772b7736deb5ee866 Fix incorrect HRP docs (Tobin C. Harding)\n9f7c21ac02e09a659f6087b24fe1ad6bd5694380 Fix links (Tobin C. Harding)\nd432a4ffad7bdbd3d51f8febfdd0dae7746bfb10 Fix rendered module docs (Tobin C. Harding)\n\nPull request description:\n\n  Do a bunch of rustdocs fixes.\n\nACKs for top commit:\n  clarkmoody:\n    ACK ea97465565cab18601665467a5a27493ec776594\n  apoelstra:\n    ACK ea97465565cab18601665467a5a27493ec776594\n\nTree-SHA512: 59505d57f5bfe12364e3fef1daaf5d45e6b4a317b1d64d2173283a5563326a919fdc5faa4d0de0b199339b00b528b1a358c43347b8bdd0effb303d5e186de222","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1925413523\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/134\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/134/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/134\">#134</a>: Do some docs fixes"}},{"before":"84b2c509c7c9c2d4911bc35d593bfce17f0abda9","after":"cb2f61ede8fcf60192a2d366fccb41ffb4380296","ref":"refs/heads/master","pushedAt":"2024-01-11T17:10:38.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#167: decode: Add accessors\n\n2fae3aa5db09806d9e5ab9f604eb1b2bafcbc289 Add UncheckedHrpstring::remove_witness_version function (Tobin C. Harding)\n0ee999d6cbfb6d4c301ef88fd0f502a0632449e5 Add UncheckHrpstring::witness_version function (Tobin C. Harding)\nb91207c835ce73c35d8b2e93ca982b17dd939294 Add ascii accessor methods (Tobin C. Harding)\n045b50a151bf52c855445e37fd2b359d7ebba5dd decode: Rename data field (Tobin C. Harding)\n\nPull request description:\n\n  This is a sexy little PR right here.\n\n  Add an `ascii` accessor method to the `UncheckedHrpstring` and `CheckedHrpstring` types.\n\n  - Patch 1 is preparation, renames the `data` field.\n  - Patch 2 is the meat and potatoes.\n\n  Fix: #160\n\nACKs for top commit:\n  apoelstra:\n    ACK 2fae3aa5db09806d9e5ab9f604eb1b2bafcbc289\n\nTree-SHA512: ce706db35d1119d3a240ffdfc11c4205b7a6052eed57019fa730ccf4643b78b5058a067b112b7bdd0e8fecf5108fe2e0ef6d2c072caeac08a08b461256318cf8","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2071504786\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/167\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/167/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/167\">#167</a>: decode: Add accessors"}},{"before":"b7642a6387bfc4d8afa45f362598cbd1f1409f7e","after":"84b2c509c7c9c2d4911bc35d593bfce17f0abda9","ref":"refs/heads/master","pushedAt":"2024-01-09T16:25:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#165: Improve error display for invalid witness version\n\ne988f3462f2df36a13ea89a44f5298c0cf6266cf Improve error display for invalid witness version (Tobin C. Harding)\nd692972844e3d8de2d5d5f40b92e0f3bd36a83cf Add rustfmt::skip to Display impl (Tobin C. Harding)\n\nPull request description:\n\n  We have two errors that cover invalid witness version, for one we print the field element which can be confusing for some values and for the other we omit the invalid version all together - we can do better.\n\n  Print the field element as well as the integer value when displaying the two invalid witness version errors.\n\n  Fix: #162\n\nACKs for top commit:\n  apoelstra:\n    ACK e988f3462f2df36a13ea89a44f5298c0cf6266cf\n\nTree-SHA512: 93d666f396c536d6348cf793b74c27363eeacec02c0a7a4ec53786778f7c64c393bad90fe10b718f872d61deb355de4b18f4fd8a66e35a1f53e09ced2cbe7c0b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2069315351\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/165\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/165/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/165\">#165</a>: Improve error display for invalid witness version"}},{"before":"6d489a781c1b005ccaeac9eca9f023843697b8aa","after":"b7642a6387bfc4d8afa45f362598cbd1f1409f7e","ref":"refs/heads/master","pushedAt":"2024-01-08T20:32:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#166: Unify hyperlinks across documentation\n\n99f6add3bd5c790939d484777cc8b26554611d9b Unify hyperlinks across documentation (bishopcheckmate)\n\nPull request description:\n\n  Hey,\n  I was browsing the master docs and found some hyperlinks broken due to missing `///` line separator.\n  I also unified the way that hyperlinks are written, and some stuff like `fmt::Write` `std::io::Write` or removed the `crate::` prefixes\n\nACKs for top commit:\n  apoelstra:\n    ACK 99f6add3bd5c790939d484777cc8b26554611d9b thanks for doing this!\n\nTree-SHA512: e26fe0913349ab48b0c568aa2c7bc213b4c88d2aa0aa6471be6dc8ce9d5b1bb279959dfc385e63232f29649fbc80e34bdb360c69873485c22a5530d6f13b1719","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2071022968\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/166\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/166/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/166\">#166</a>: Unify hyperlinks across documentation"}},{"before":"c5c028e32ddfa9a12fd014991f83dd277ada368a","after":"6d489a781c1b005ccaeac9eca9f023843697b8aa","ref":"refs/heads/master","pushedAt":"2024-01-08T15:16:49.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#164: Make `from_char_unchecked` public\n\nca2f840fca0c9a398863923df04122e8e201c3c5 Make from_char_unchecked public (Tobin C. Harding)\nb7767ee90b54fc6b1a6fada1bf077f535dc55fd0 Split gf32::Error (Tobin C. Harding)\n\nPull request description:\n\n  - Patch 1 is an error type clean up, part of this PR because it improves the error type returned by `from_char`.\n  - Patch 2 documents the error return of `from_char` and makes `from_char_unchecked` public.\n\n  Fix: #161\n\nACKs for top commit:\n  apoelstra:\n    ACK ca2f840fca0c9a398863923df04122e8e201c3c5\n\nTree-SHA512: 758c7d9bdb5f5ac1e24b379376f87caf0a0ee2af32409ac4c7e1e009b822c7ee400d69c2cf991472e06acf4bd27e7d93521d08565f319fc125b48fe386f7b3f8","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2069308765\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/164\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/164/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/164\">#164</a>: Make <code>from_char_unchecked</code> public"}},{"before":"072be531c7c677a201abd6dfbf0d0eb231594ae7","after":"c5c028e32ddfa9a12fd014991f83dd277ada368a","ref":"refs/heads/master","pushedAt":"2024-01-05T15:26:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#163: Fix typo\n\n68bb5396ceba9a89e84716e99d4cf02c4a533970 Fix typo (GoodDaisy)\n\nPull request description:\n\nACKs for top commit:\n  apoelstra:\n    ACK 68bb5396ceba9a89e84716e99d4cf02c4a533970\n\nTree-SHA512: ba935bde9c3a5efab55af093bfc902379f0d63dc1fb0b534e4eb20c91f309bf41b16e987f3f3421cd6c9388abafb2700e79fb68e55195db7f5f8a1ebd5753056","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2066570131\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/163\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/163/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/163\">#163</a>: Fix typo"}},{"before":"2b3f42ff176d3e8f6165f3e90625cdfcbf783047","after":"072be531c7c677a201abd6dfbf0d0eb231594ae7","ref":"refs/heads/master","pushedAt":"2023-12-04T22:11:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#158: Add a returns section to the docs on segwit::decode\n\n6de909e7bd503019371fddd5fe49857e65c25117 Add a returns section to the docs on segwit::decode (Tobin C. Harding)\n\nPull request description:\n\n  We return a 3 element tuple but do not document what it is or the guarntees on the vector length. Do so.\n\nACKs for top commit:\n  Kixunil:\n    ACK 6de909e7bd503019371fddd5fe49857e65c25117\n  apoelstra:\n    ACK 6de909e7bd503019371fddd5fe49857e65c25117\n\nTree-SHA512: e9c5713306906081d996df3b0dee3444ffd1d41f4d54b693be285c3a7e0a2351d1f1054dd37702879d4ac9cdace27164a24684f534b84bc7f0f9d15d7d30289a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2023008446\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/158\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/158/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/158\">#158</a>: Add a returns section to the docs on segwit::decode"}},{"before":"ac744158f7ce987f0d351d6565343e02412cbaec","after":"2b3f42ff176d3e8f6165f3e90625cdfcbf783047","ref":"refs/heads/master","pushedAt":"2023-11-06T13:36:58.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#138: Add buffering during encode\n\nc215c3d596761a4f4bf32be62ffbacd17081fe41 Add a buffer when writing (Tobin C. Harding)\n94625e7e043fe34e1417498ed927a8cbd0e65887 segwit: Add a buffer when writing (Tobin C. Harding)\n596f1f7bab5c8c9d08782d03379418373b0e1b14 Add encode::ByteIter (Tobin C. Harding)\n\nPull request description:\n\n  Currently we write char at a time to both writers (`fmt::Write` and `std::io::Write`). We can improve performance by first collecting the ASCII bytes of the encoded bech32 string into a buffer on the stack then writing the buffer as a single call.\n\n  This is purely an optimization.\n\n  The second patch is surprising, at least to me, would love to learn what I'm doing wrong. I thought this would be valid\n  ```rust\n  let mut buf = [0_u8; Ck::CODE_LENGTH]\n  ```\n\n  But the compiler does not like the usage of an associated const.\n\nACKs for top commit:\n  apoelstra:\n    ACK c215c3d596761a4f4bf32be62ffbacd17081fe41\n\nTree-SHA512: 41f2f70f44b35736e2a8aec210daa6f73a8e97f31d165c97bc7b32d7b28e066ef29a17f105872071d0f4bc84e5883f2d4cbed65ac748cae663819a316bfda1f9","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1946243196\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/138\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/138/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/138\">#138</a>: Add buffering during encode"}},{"before":"2e06b367bcfcdff7f4ee280caf10a0f200348ee8","after":"ac744158f7ce987f0d351d6565343e02412cbaec","ref":"refs/heads/master","pushedAt":"2023-10-27T00:06:40.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#142: Enforce maximum length\n\n12d7b385c075d44761704089a9cdcc8ad8fd0c35 Enforce maximum string length (Tobin C. Harding)\nf5bd09ba9e21ff817a666829413d286f53fbb653 Add encoded_length functions (Tobin C. Harding)\n\nPull request description:\n\n  Enforce maximum string length when encoding.\n\n  Fix: #140\n\nACKs for top commit:\n  apoelstra:\n    ACK 12d7b385c075d44761704089a9cdcc8ad8fd0c35\n\nTree-SHA512: cbfa1507ae37cc24b26001399e1ebb908c2a7086c18149e1061d3b14d3590ca8f007fbe80948736de326cceb59320df4b4dcce886a4790b25d5ba4b3ed802996","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1946485170\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/142\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/142/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/142\">#142</a>: Enforce maximum length"}},{"before":"d60e09d76dd47ea31bc97e215e22a88b5235fd0c","after":"2e06b367bcfcdff7f4ee280caf10a0f200348ee8","ref":"refs/heads/master","pushedAt":"2023-10-25T22:26:44.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#154: Do a bunch of cleanups\n\n8426386b845740cff41520ad56fa086fc2640bdf Use string not address in lib.rs (Tobin C. Harding)\nc9aa166e05e9d3f97d8b6f6a6a4cafaaa7404ab6 Use NoData instead of MissingWitnessVersion (Tobin C. Harding)\n2eac8e65cdd7b7dc12169aff4154ce3e03b601ab Fix colum width typo in rustdoc (Tobin C. Harding)\n\nPull request description:\n\n  This is the first 4 patches from #142, pushing up separately because that PR is quite complicated to review well and these cleanups are unrelated.\n\nACKs for top commit:\n  apoelstra:\n    ACK 8426386b845740cff41520ad56fa086fc2640bdf\n\nTree-SHA512: 154bce12df068e80f17aa3fa5096390ce43eafd5efb9ed2319e0e26767ebb178b729f268bdb2a76c8a709c867d226d67522999da31dbb6f0bc30eb7106c0be9e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1960380984\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/154\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/154/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/154\">#154</a>: Do a bunch of cleanups"}},{"before":"76918c501b8540c684dbc3e9f6470f2e0a4077fe","after":"d60e09d76dd47ea31bc97e215e22a88b5235fd0c","ref":"refs/heads/master","pushedAt":"2023-10-24T13:29:57.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#152: Add a justfile\n\na39b6f539363bac76ffbfcde6e7ed1e7ebd75245 Add a justfile (Tobin C. Harding)\n\nPull request description:\n\n  Introduce usage of `just` by adding a justfile.\n\n  ref: https://github.com/casey/just\n\nACKs for top commit:\n  apoelstra:\n    ACK a39b6f539363bac76ffbfcde6e7ed1e7ebd75245\n\nTree-SHA512: 9220301600ca6a22c8253005a454cad83ce3e65c9312122acb282f6b14a59c99785b34eb1c8131a8e61cf65c77739e5ad41e2705332e08d2d8ea297faac1763d","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1958386046\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/152\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/152/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/152\">#152</a>: Add a justfile"}},{"before":"7207926e5a4781e08b59056ba230d6250136173f","after":"76918c501b8540c684dbc3e9f6470f2e0a4077fe","ref":"refs/heads/master","pushedAt":"2023-10-22T20:36:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#150: Fix checksum error type\n\neeb434f37b87df52e8a9574107b2840fe0a1e5ef Fix checksum error type (Tobin C. Harding)\n\nPull request description:\n\n  We have a couple of checksum error problems;\n\n  - Unused checksum related variants in `CharError`\n  - Unuseful error message (duplicated string \"invalid checksum\")\n\n  Fix both at the same time by removing the unused variants from `CharError` and by renaming the `InvalidChecksum` variant to `InvalidResidue` and improving the `Display` impl appropriately.\n\nACKs for top commit:\n  apoelstra:\n    ACK eeb434f37b87df52e8a9574107b2840fe0a1e5ef\n\nTree-SHA512: 6d0cd477951c2e9e838f3466f2114a0dc9a575c16085eea2173d971c23f8058d342c9b44b5410286a31c9e9ad4619a0a5241d1d540d0540044cdb018a195c4a8","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1956018713\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/150\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/150/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/150\">#150</a>: Fix checksum error type"}},{"before":"413e8b5994f9ea055094c264f20f2b8932925629","after":"7207926e5a4781e08b59056ba230d6250136173f","ref":"refs/heads/master","pushedAt":"2023-10-21T14:47:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#148: Use pass-by-copy for Hrp when possible\n\nfaf8651b9b3706fcb899ab3300f72707a9d1958d Use pass-by-copy for Hrp when possible (Tobin C. Harding)\n\nPull request description:\n\n  We currently have some code that uses pass-by-reference and some that uses pass-by-copy.\n\n  Further investigation shows that when messing with iterators we have to have a reference to the `Hrp` so that the iterator has somewhere in memory to point to while iterating.\n\n  The iterator API is intentionally low level, we can make the higher level APIs more ergonomic by using pass-by-copy.\n\nACKs for top commit:\n  apoelstra:\n    ACK faf8651b9b3706fcb899ab3300f72707a9d1958d\n\nTree-SHA512: c7e547033cdec865d887b82ddc0a7c38762693dbf77851355c584afde1082bac1c046f4b4c2ac22a2f016b0a599974701a0ac0914c91629787259747df47d8c2","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1950916233\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/148\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/148/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/148\">#148</a>: Use pass-by-copy for Hrp when possible"}},{"before":"13b3f47f0b4cf2473b2c540d84500a655dc5c2b0","after":"413e8b5994f9ea055094c264f20f2b8932925629","ref":"refs/heads/master","pushedAt":"2023-10-19T14:45:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#149: Remove unnecessary call to to_ascii_lowercase\n\nb6233c8ef041e7d6159fb86e86ff93c611449bce Remove unnecessary call to to_ascii_lowercase (Tobin C. Harding)\n\nPull request description:\n\n  We already iterate over lowercase characters when encoding a bech32 string, no need to call `to_ascii_lowercase`.\n\n  Add a unit test as documentation of this behavior as well as to verify the change is correct.\n\nACKs for top commit:\n  apoelstra:\n    ACK b6233c8ef041e7d6159fb86e86ff93c611449bce\n\nTree-SHA512: f2a7ef807645b00ae4d87cdeb138624b52b322fc51d9dd0c86076e7ce2c4408aee1333dda1fdf78ee4b59c57334b31f39c4ab0c2e1f2863dd4e2d80aa681c30e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1950979955\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/149\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/149/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/149\">#149</a>: Remove unnecessary call to to_ascii_lowercase"}},{"before":"e4c61b570894bf3ec70f50d5d78f4e5ccfeed0dc","after":"13b3f47f0b4cf2473b2c540d84500a655dc5c2b0","ref":"refs/heads/master","pushedAt":"2023-10-19T14:20:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#147: Rename `EncodeError::Write` variant to `Fmt`\n\n3e729c31ffeb6e0bb7ee46a463b75de673060a94 Rename EncodeError::Write variant to Fmt (Tobin C. Harding)\n\nPull request description:\n\n  We typically refer to a \"fmt\" being an object that implements `fmt::Write` e.g, `encode_to_fmt()`.\n\n  Currently we are using the variant name `Write` for an error variant that holds a `fmt::Error`, while this is correct in a way it is also confusing because we may one day have an `io::Error` (coming from a `io::Write` writer).\n\n  Use `EncodeError::Fmt` instead of `Write`.\n\nACKs for top commit:\n  apoelstra:\n    ACK 3e729c31ffeb6e0bb7ee46a463b75de673060a94\n\nTree-SHA512: 35073fe871830a15762e541547ef7e0fcbd18ef6aabe0bdd84a0c6bfadea65eb345482f6c0275f3497a30ae2c994454a18a29e22386cb94b67a6fe735a9d8ff5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1950916031\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/147\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/147/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/147\">#147</a>: Rename <code>EncodeError::Write</code> variant to <code>Fmt</code>"}},{"before":"8de5f3169385016e2809225e910145982beb87cc","after":"e4c61b570894bf3ec70f50d5d78f4e5ccfeed0dc","ref":"refs/heads/master","pushedAt":"2023-10-19T14:03:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#146: Feature guard write_err import\n\nc16b68a92982f02c337c84aa0a6bc47aaca97f95 Feature guard write_err import (Tobin C. Harding)\n\nPull request description:\n\n  We only use the `write_err` macro when the \"alloc\" feature is enabled, the import statement should be feature guarded.\n\n  Clears a clippy warning.\n\nACKs for top commit:\n  apoelstra:\n    ACK c16b68a92982f02c337c84aa0a6bc47aaca97f95\n\nTree-SHA512: b274697f24abc0d3376f29e7ba8162e959b3ef4c449e061e662e94d06c94873116f7db96dc1fb702b440d9fc3d2bfb93e291ea5d631c9a5038cb7cea76913eef","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1950915988\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/146\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/146/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/146\">#146</a>: Feature guard write_err import"}},{"before":"fb3ff2db7fe931a415850d1f650dd07e68727d9d","after":"8de5f3169385016e2809225e910145982beb87cc","ref":"refs/heads/master","pushedAt":"2023-10-18T17:18:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#145: Add Hrp::{as_bytes, as_str}\n\nfedd38c9753e3c4a943572322e826fe23bc5459c Add Hrp::{as_bytes, as_str} (Thibault Martinez)\n\nPull request description:\n\n  Fixes https://github.com/rust-bitcoin/rust-bech32/issues/143\n\nACKs for top commit:\n  apoelstra:\n    ACK fedd38c9753e3c4a943572322e826fe23bc5459c\n  tcharding:\n    ACK fedd38c9753e3c4a943572322e826fe23bc5459c\n\nTree-SHA512: 4869006d0bd59478a32ac91064c6da38ea9dc2c68f2c18759b9b2ba5a525bfe26a0603c5d8fe28a631ae10c21da4810fdbc94965567d78f404e2118ebb31b203","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1948117100\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/145\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/145/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/145\">#145</a>: Add Hrp::{as_bytes, as_str}"}},{"before":"202b59fd3fe4491fcbfa4b53a8c5a64feb49f20f","after":"fb3ff2db7fe931a415850d1f650dd07e68727d9d","ref":"refs/heads/master","pushedAt":"2023-10-17T15:59:08.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#139: Improve errors\n\nc89065db166a1c2cac018d638e031ef98f93558e Make struct error internals public (Tobin C. Harding)\nac24f23754a893199b27fa364d24027a6672d32e Remove unused error types (Tobin C. Harding)\n\nPull request description:\n\n  Audit all error types as per discussion in https://github.com/rust-bitcoin/rust-bitcoin/issues/820\n\n  I believe with these patches applied we are good to go for v1.0 in regards to error handling.\n\nACKs for top commit:\n  apoelstra:\n    ACK c89065db166a1c2cac018d638e031ef98f93558e\n\nTree-SHA512: 1f0f49c5c6b42c51001544b213f0a9109e92a64458959e328fb0c7f8d01b47bfa56da47cba6bcb73096418a4873cb643cbc8c6e124923db0f5389985baaac511","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1946280935\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/139\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/139/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/139\">#139</a>: Improve errors"}},{"before":"7c3ddff5e2237e5ab29f572bbf997325d412d906","after":"202b59fd3fe4491fcbfa4b53a8c5a64feb49f20f","ref":"refs/heads/master","pushedAt":"2023-10-12T15:09:04.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"apoelstra","name":"Andrew Poelstra","path":"/apoelstra","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1351933?s=80&v=4"},"commit":{"message":"Merge rust-bitcoin/rust-bech32#137: Improve public re-exports\n\n1d4d3372552da33848bc9b4aa6a08ae046f13990 Separate public and private use statements (Tobin C. Harding)\n\nPull request description:\n\n  Improve the public exports in two ways:\n\n  1. Inline re-exports into the docs of the module that re-exports them.\n  2. Separate public and private use statements\n\n  Recently we discussed a way to separate the public and private import statements to make the code more clear and prevent `rustfmt` joining them all together.\n\n  Separate public exports using a code block and `#[rustfmt::skip]`. Has the nice advantage of reducing the number of `#[doc(inline)]` attributes also.\n\n  1. Modules first, as they are part of the project's structure.\n  2. Private imports\n  3. Public re-exports (using `rustfmt::skip` to prevent merge)\n\n  Use the format\n\n  ```rust\n  mod xyz;\n  mod abc;\n\n  use ...;\n\n  pub use {\n      ...,\n  };\n  ```\n\n  This patch introduces changes to the rendered HTML docs.\n\nACKs for top commit:\n  clarkmoody:\n    ACK 1d4d3372552da33848bc9b4aa6a08ae046f13990\n  apoelstra:\n    ACK 1d4d3372552da33848bc9b4aa6a08ae046f13990\n\nTree-SHA512: bdeeb862ea7e1e91f9dbfcce2beff99aedd0bf8cc916607237dff32e2f20be7cb70ef4235d0a823dfea30bd4bf48e0bafbcfa43e13402c7ddf5aadd7a83b64b1","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1934265989\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-bitcoin/rust-bech32/issues/137\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-bitcoin/rust-bech32/pull/137/hovercard\" href=\"https://github.com/rust-bitcoin/rust-bech32/pull/137\">#137</a>: Improve public re-exports"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEDPxWWwA","startCursor":null,"endCursor":null}},"title":"Activity · rust-bitcoin/rust-bech32"}