Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to bitcoin based version #65

Open
RCasatta opened this issue May 13, 2022 · 6 comments
Open

Consider switching to bitcoin based version #65

RCasatta opened this issue May 13, 2022 · 6 comments

Comments

@RCasatta
Copy link
Collaborator

For example when bitcoin core 24.0 come out, add support for it and crate version could become 24.0-x.y

@casey
Copy link

casey commented Jul 27, 2022

This seems like a good idea! The current setup is somewhat tricky to use, since you have to remember to specify a feature. So just specifying one version for the crate and getting the bitcoind version you want would be easier.

@RCasatta
Copy link
Collaborator Author

What you describe is not exactly what I had in mind. Features will stay and there will be no default feature enabled because by default I want to support setups where bitcoind executable is already in PATH or where BITCOIND_EXE env var is specified.

What I was considering with this issue is that bitcoind crate version 24.0-x.y is the first version supporting the feature 24_0

@casey
Copy link

casey commented Jul 28, 2022

Ah, gotcha, makes sense. Would it make sense to split bitcoind into two crates, one that downloads bitcoind, and one that runs it? They seem like two distinct pieces of functionality. Then, the version of bitcoind that download the crates could use the same versioning scheme as bitcoind itself.

@RCasatta
Copy link
Collaborator Author

Then, the version of bitcoind that download the crates could use the same versioning scheme as bitcoind itself.

But do you imagine crate bitcoind_download version 23.0 can only download that version?
It's useful to test against the older versions

@casey
Copy link

casey commented Jul 29, 2022

But do you imagine crate bitcoind_download version 23.0 can only download that version?
It's useful to test against the older versions

You could use a previous version of bitcoin_download to test older versions. And you could also use multiple versions to test different versions at the same time. I don't think that's possible with features.

@casey
Copy link

casey commented Jul 29, 2022

Or, wait, I think it is, you would just have two dependencies with different names and with different features turned on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants