Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: args: Vec<&str> #39

Open
RCasatta opened this issue Dec 2, 2021 · 1 comment
Open

Change: args: Vec<&str> #39

RCasatta opened this issue Dec 2, 2021 · 1 comment

Comments

@RCasatta
Copy link
Collaborator

RCasatta commented Dec 2, 2021 •
edited

using Vec<&str> as args in Conf doesn't allow the caller to use String, use something allowing that (T: Borrow<&str>, Vec<T>?)
@RCasatta RCasatta changed the title Change: args: Vec<&str> Change: args: Vec<&str> Dec 2, 2021
@RCasatta RCasatta mentioned this issue May 13, 2022
Open
@RCasatta RCasatta mentioned this issue Jul 28, 2022
Merged
@Kixunil
Copy link

Kixunil commented Dec 23, 2022

Args should really be OsString, or in this case you probably want Cow<'a, OsStr>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kixunil @RCasatta