Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency] Half 1.8.1 MSRV issue #1435

Closed
homersimpsons opened this issue Oct 22, 2021 · 2 comments
Closed

[Dependency] Half 1.8.1 MSRV issue #1435

homersimpsons opened this issue Oct 22, 2021 · 2 comments

Comments

@homersimpsons
Copy link
Contributor

half just released a new version (1.8.1). This version does not support Rust Version under 1.51.

An issue has been open on the upstream repository: starkat99/half-rs#48

nom currently has a MSRV of 1.41.1 which is too low for this dependency.

@Geal / @Stargateur

@Stargateur
Copy link
Contributor

Stargateur commented Oct 22, 2021

MSRV for nom 7 is 1.48 but the current test is still for 1.41 see Geal comment:

if possible, I'd like to keep nom usable on 1.41.1 for now. As said in the readme, it works on that version without guarantee, but the debian stable upgrade happened quite recently, so people have not migrated quickly to the new version (which has a more recent rustc)

For MSRV 1.51 according to nom policy this would have to wait for nom 8.

half fixed their build starkat99/half-rs#48 (comment)

@Geal
Copy link
Collaborator

Geal commented Oct 23, 2021

yup, it is fixed now, and with #1435 we should reduce the risk of future issues like this

@Geal Geal closed this as completed Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants