Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion from FromSqlError to Error #556

Merged
merged 1 commit into from
Aug 5, 2019
Merged

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Aug 4, 2019

Error needs column index, but FromSqlError doesn't have it. I've fudged it by putting obviously-wrong index value, and then hiding that fact in Display.

Ideally the Error should use Option<usize> for index (and type), but I assume it's better to avoid unnecessary backwards-compat break.

Fixes #555

@kornelski
Copy link
Contributor Author

The test failure looks like a vcpkg installation issue, unlikely to be related to this change.

@gwenn gwenn merged commit 4e36b55 into rusqlite:master Aug 5, 2019
@gwenn
Copy link
Collaborator

gwenn commented Aug 5, 2019

Thank you.

@kornelski kornelski deleted the fromsqlerr branch August 5, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There's no From for FromSqlError to Error
2 participants