Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bundled-windows feature #537

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Jun 21, 2019

This allows a dependency to use build_bundled on windows and build_linked everywhere else. This is currently not possible because cargo doesn't support target-specific features and selecting the bundled feature for windows would enable the bundled feature everywhere.

Related: rust-lang/cargo#1197

@thomcc
Copy link
Member

thomcc commented Jun 21, 2019

FWIW I'm pretty sure you can work around the lack of target-specific features by having a target-specific dependency on a dummy crate that does nothing but turn on the feature.

I don't oppose adding this, though.

@kpcyrd
Copy link
Contributor Author

kpcyrd commented Jun 21, 2019

I've considered using a dummy crate, but figured it would be cleaner to add it to libsqlite3-sys instead, especially when packaging the resulting tree for distros.

@gwenn gwenn merged commit b632c0f into rusqlite:master Jun 21, 2019
@gwenn
Copy link
Collaborator

gwenn commented Jun 21, 2019

Thanks.

@kpcyrd kpcyrd deleted the bundled-windows branch June 21, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants