Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when building with uuid and functions features. #515

Merged
merged 3 commits into from
Apr 28, 2019

Conversation

derekdreery
Copy link
Contributor

No description provided.

@gwenn
Copy link
Collaborator

gwenn commented Apr 26, 2019

Would you mind updating the travis script ?

-  - cargo test --features "backup blob chrono csvtab functions hooks limits load_extension serde_json trace url vtab"
+  - cargo test --features "backup blob chrono csvtab functions hooks limits load_extension serde_json trace url uuid vtab"

@derekdreery
Copy link
Contributor Author

derekdreery commented Apr 26, 2019

Sure, but I'm not sure this patch is correct yet. Are the error types I'm converting to correct? I don't know if they are at present.

EDIT They probably are correct.

@derekdreery
Copy link
Contributor Author

I think this is ready for review again. :)

@gwenn gwenn merged commit 584d94d into rusqlite:master Apr 28, 2019
@gwenn
Copy link
Collaborator

gwenn commented Apr 28, 2019

Thanks.

@derekdreery derekdreery deleted the patch-1 branch April 28, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants