Allow specifying both sqlcipher and bundled.
#511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
force-pushed
the
no-sqlcipher-bundled-panic
branch
from
251147a
to
3099db5
Compare
4 tasks
This is useful because currently, when using `rusqlite` in a Cargo workspace with one crate that uses `sqlcipher` and another that uses `bundled`, a build error will be triggered by an unqualified `cargo build` (as cargo will use the union of all features enabled by crates in the workspace). Instead of panicing, this just emits a warning, before (mostly) ignoring that the `bundled` feature was specified. Note: in this configuration, we still use our bundled bindings, to avoid changing `rusqlite` to handle this edge case (hence 'mostly').
thomcc
force-pushed
the
no-sqlcipher-bundled-panic
branch
from
3099db5
to
fe80b51
Compare
gwenn
reviewed
Apr 23, 2019
|
We'd appreciate a release going out when you next have the opportunity to do so, to get https://github.com/mozilla/application-services/ off of my branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful because currently, when using
rusqlitein a Cargo workspace with one crate that usessqlcipherand another that usesbundled, a build error will be triggered by an unqualifiedcargo build(as cargo will use the union of all features enabled by crates in the workspace).Instead of panicing, this just emits a warning, before (mostly) ignoring that the
bundledfeature was specified. Note: in this configuration, we still use our bundled bindings, to avoid changingrusqlitetohandle this edge case (hence 'mostly').