Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify instruction for building with vcpkg #483

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Conversation

technic
Copy link
Contributor

@technic technic commented Feb 17, 2019

Mention VCPKGRS_DYNAMIC=1 environment variable,
and the fact that you need to run cargo clean in order to force rebuild.

Mention VCPKGRS_DYNAMIC environment variable.
@gwenn
Copy link
Collaborator

gwenn commented Feb 17, 2019

Would you mind testing the following change:
Add this line:

if cfg!(all(feature = "vcpkg", target_env = "msvc")) {
    println!("cargo:rerun-if-env-changed=VCPKGRS_DYNAMIC");
}

here: https://github.com/jgallagher/rusqlite/blob/master/libsqlite3-sys/build.rs#L133

Add then check that you don't need to clean anymore.

@technic
Copy link
Contributor Author

technic commented Feb 17, 2019

@gwenn
I can readily test it on windows. How can tell cargo to use local git instead of upstream crates source?

@gwenn
Copy link
Collaborator

gwenn commented Feb 18, 2019

@technic
Copy link
Contributor Author

technic commented Feb 18, 2019

Awesome, every time I am gladly surprised how rust developers though through all scenarios in advance.
I would check it!

@technic
Copy link
Contributor Author

technic commented Mar 24, 2019

@gwenn
Your fix works. Pull request updated, thanks!

@gwenn gwenn merged commit b24f3c5 into rusqlite:master Mar 25, 2019
@gwenn
Copy link
Collaborator

gwenn commented Mar 25, 2019

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants