Add params/named_params macro, and expose ToSql from top level #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/jgallagher/rusqlite/graphs/contributors => third. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody asked for
named_params!, but it would be nice. It would be nicer if it were supported as the params! macro, but doing that would require a lot more work (see https://github.com/serde-rs/json/blob/master/src/macros.rs, for example).I've also made some of the examples and tests use this, although not all of them as the intent isn't to deprecate passing these explicitly, just to make doing it more convenient.
Re-exposing ToSql from the top level is done just to make it more obvious. It's a fairly important part of the API, and it feels buried for it to live in
rusqlite::types::.Fixes #462.