New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignoring errors #109
Comments
Hey @pawelgnatowski , thank you for your report and glad that you found this tool useful. I'll see what I can do with this. |
|
You may be right - i actually have tried full export first but due to another error and sheer size of 5k channels i wanted to limit the amount of channels, the only way i found is by providing channel list. Command: |
Ah, it makes sense now. Re starred items - no, for now Slackdump is quite simple - only gets channels, users, and conversations.
|
sounds good, any ETA on the 1,3 - need to know how dirty i need to make my hands, as time window is closing fast. btw - i tried slack export viewer - i guess it is either full export or it does not work :( |
Sorry, no ETA on this - i do it in my free time, features are plentiful, and I got only two hands 😂 But I'll see what I can do |
When I released it open source I hoped that there'd be people contributing, as it seems to be helpful, but I guess the time hasn't come yet. |
wish i could - haven't picked up Go yet. |
That's no problem, Pawel :) Feature suggestion or bug report are also great contributions, feedback loop is very important. |
i definitely must go for 1 & 3 which means i'll probably use node or python for it. Can share some lessons learned for the APIs you have mentioned. Thanks for doing this project. Kudos! |
Thank you :) |
@pawelgnatowski I have made a quick and not so dirty patch to my fork of the slack library that will treat "null" as zero unix time (Jan 1,1970), and built a windows binary out of it,(attached |
Also, I don't think that ignoring this kind of errors will work - each api call returns a next token, that might be nil in case that the error occurs, so it would not be possible to get the next "page". Let's see if the quickfix from my previous comment works. Regarding 503 and the server-class errors in general, I think it would be possible to handle it along with 429 rate limit errors, but in this case we'd have to wait at increasing time intervals, i.e. 1st attempt fails, wait 30 seconds, next attempt fails, wait 60 seconds, etc. |
|
|
Seems like a false positive? Anyway, I can understand the lack of trust. Here are the changes in slackdump: and here are the changes in the slack lib fork: Would you be able to checkout and build branch |
Hey, not about trust, just literally it was blocked by browsers. I will be back in a couple of days and will try then. |
gave the zip file another try and it works ^_^, guess M$ updated defender or smth. |
Thanks! Looks like there's some malformed file within that channel - there's an ID of this file ("FGHGC2XFG"), but no name, no URL etc. Very strange. But glad to hear that it works, I basically modified the slack library to ignore empty JSONTime. I'll submit the PR to upstream slack library. If that doesn't get through, i'll just maintain the change in the fork. |
I have prepared a tool for #115, that shows the RAW output of the API - can I ask you to run it on that channel, and copy/paste the JSON for that file object with "ID": "FGHGC2XFG". Would be interesting to see what in the actual fuck is going on over there? It uses the same auth as the slackdump, so you could run it like this: rawoutput.exe channel_id it will generate the |
|
Very interesting - it looks like it's a "deleted remote file" according to the this doc Probably they are so rare, that no one ever had this special case with the slack lib. I searched through their issues and was unable to find anything on this. Thank you! |
TODO:
|
@pawelgnatowski I was trying to reproduce this the other day, the same way I did with #119 (the test code is in the issue I've opened with slack lib slack-go/slack#1104), however I did not get the unmarshal error, until I've added a
Thank you! |
|
Excellent, thank you! Reproduced straight away!
|
Created an issue slack-go/slack#1107 and PR slack-go/slack#1106 for the upstream library. |
Btw. The stars and reactions API is super straight forward |
Hey @pawelgnatowski , sorry, I was too focused on the API issue, and the reactions and bookmarks completely slipped my mind. I'll create a separate issue for those, not to lose track. |
No prob, like you said, you do it when you do it. |
@pawelgnatowski Have a look at this discussion: #127 |
Merged the upstream slack library. |
Describe the bug
while bugs are encountered, export process terminates
To Reproduce
Steps to reproduce the behavior:
slackdump -f -export MyDump @channelList.txt
Expected behavior
Continue or prompt if to ignore error.
Output
2022/08/16 13:53:39 application error: export error: failed to dump "xyz" (xxx): callback error: failed to dump channel xxx: strconv.Atoi: parsing "null": invalid syntax
Desktop (please complete the following information):
Windows
Additional context
Same problem occurs if there is temporary slack down time e.g. 503 error.
For larger exports it may take time to process.
It would be good to expose flags to ignore error and/or retry X times after Y time then ignore or exit.
Now i need to forgo entire channel as it is failing. Also had to write script that compares continent if other channels fail (not fatally) and can be restarted later.
Otherwise gj bro!
The text was updated successfully, but these errors were encountered: