Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECR SDK Is Missing Parameter on GetAuthorizationTokenRequest #1974

Open
xrl opened this issue Mar 25, 2022 · 2 comments
Open

ECR SDK Is Missing Parameter on GetAuthorizationTokenRequest #1974

xrl opened this issue Mar 25, 2022 · 2 comments

Comments

@xrl
Copy link
Contributor

xrl commented Mar 25, 2022

I need the registry_ids parameters on the ECR GetAuthorizationTokenRequest. Currently https://github.com/rusoto/rusoto/blame/master/rusoto/services/ecr/src/generated.rs#L516

#[derive(Clone, Debug, Default, PartialEq, Serialize)]
#[cfg_attr(feature = "deserialize_structs", derive(Deserialize))]
pub struct GetAuthorizationTokenRequest {}

But what worked 15 months ago: https://github.com/rusoto/rusoto/blame/553d1eda9a87b8c214911273811dcfab9f9faf6b/rusoto/services/ecr/src/generated.rs#L466

pub struct GetAuthorizationTokenRequest {
    /// <p>A list of AWS account IDs that are associated with the registries for which to get AuthorizationData objects. If you do not specify a registry, the default registry is assumed.</p>
    #[serde(rename = "registryIds")]
    #[serde(skip_serializing_if = "Option::is_none")]
    pub registry_ids: Option<Vec<String>>,
}

What's the best way to fix this?

@xrl
Copy link
Contributor Author

xrl commented Mar 25, 2022

The specific version of the botocore submodule has the registryIds parameter: https://github.com/boto/botocore/blob/2f60d8b442b12d8519184f220a21975e56b7b114/botocore/data/ecr/2015-09-21/service-2.json#L1161 . So it must be the codegen tool that is dropping the field?

@xrl
Copy link
Contributor Author

xrl commented Mar 25, 2022

Ah, I see the issue, the registryIds property is deprecated:

This field is deprecated. The returned authorization token can be used to access any Amazon ECR registry that the IAM principal has access to, specifying a registry ID doesn't change the permissions scope of the authorization token.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant