Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gem::GemPathSearcherクラスの[SEE_ALSO]リンクを修正 #2853

Merged
merged 2 commits into from
May 21, 2024
Merged

Gem::GemPathSearcherクラスの[SEE_ALSO]リンクを修正 #2853

merged 2 commits into from
May 21, 2024

Conversation

niikz
Copy link
Contributor

@niikz niikz commented Dec 10, 2023

@otegami otegami mentioned this pull request Dec 11, 2023
Closed
znz
znz reviewed May 1, 2024
View reviewed changes
Copy link
Member

@znz znz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同名のメソッドと同じような挙動という意味での see だと思うので、見出しになっているメソッド名にこだわらずに [[m:Enumerable#find]] と [[m:Enumerable#find_all]] の方が良さそうだと思いました。

@niikz
Copy link
Contributor Author

niikz commented May 21, 2024

ご確認ありがとうございます！
元のメソッド名にあわせて修正しました。

znz
znz approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@znz znz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。

@znz znz merged commit 17a7847 into rurema:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@znz znz znz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GemPathSearcherクラスのSEE_ALSOのリンク切れがありました。
2 participants
@niikz @znz