Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leak: git scm plugin accessed via API #5301

Closed
gschueler opened this issue Sep 26, 2019 · 2 comments · Fixed by #5304
Closed

memory leak: git scm plugin accessed via API #5301

gschueler opened this issue Sep 26, 2019 · 2 comments · Fixed by #5304
Assignees
@gschueler
Labels
bug
Milestone
3.1.2

Comments

@gschueler
Copy link
Member

Describe the bug

Rundeck fails with OOM error after running for a while. Heap dump indicates SCM service is causing a memory leak. Code paths indicate API calls for scm status may cause the leak.

My Rundeck detail

  • Rundeck version: 3.0.x

To Reproduce
Steps to reproduce the behavior:

(untested)

  1. Enable git scm plugin for project(s)
  2. Repeatedly use API to query scm status of project/jobs
  3. observe memory usage increasing

Expected behavior

Repeated SCM Status API calls should not increase memory usage
@gschueler gschueler added the bug label Sep 26, 2019
@gschueler gschueler self-assigned this Sep 26, 2019
gschueler added a commit that referenced this issue Sep 26, 2019
@gschueler
Fix #5301 fix initProject, and clean old listeners
256506c 
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
@gschueler gschueler mentioned this issue Sep 26, 2019
Merged
gschueler added a commit that referenced this issue Sep 27, 2019
@gschueler
Merge pull request #5304 from rundeck/issue/5301
450260d 
Fix #5301 fix initProject, and clean old listeners
@gschueler gschueler added this to the Sprint 40 milestone Sep 27, 2019
@gschueler
Copy link
Member Author

needs backport: 3.0

@gschueler gschueler mentioned this issue Sep 27, 2019
Closed
@gschueler gschueler modified the milestones: Sprint 40, 3.1.2 Sep 27, 2019
@gschueler
Copy link
Member Author

needs backport: 2.x

@gschueler gschueler mentioned this issue Sep 27, 2019
Closed
gschueler added a commit that referenced this issue Sep 27, 2019
@gschueler
Fix #5301 fix initProject, and clean old listeners
f2c312e 
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
@gschueler gschueler mentioned this issue Sep 27, 2019
Merged
gschueler added a commit that referenced this issue Sep 27, 2019
@gschueler
Fix #5301 fix initProject, and clean old listeners
eb723a4 
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Sep 30, 2019
@gschueler
Fix #5301 fix initProject, and clean old listeners
c2f9610 
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Oct 1, 2019
@gschueler
Fix #5301 fix initProject, and clean old listeners
457b3e2 
* prevents multiple listeners for the same project+integration plugin
from accumulating after repeated scm status queries
* same when scm plugins are re-enabled or re-configured
gschueler added a commit that referenced this issue Oct 1, 2019
@gschueler
Merge pull request #5309 from rundeck/issue/5307/backport
33b04f1 
[2.11 backport] Fix #5301 fix initProject, and clean old listeners
@SpencerMalone SpencerMalone mentioned this issue Oct 31, 2019
Closed
@sjrd218 sjrd218 mentioned this issue Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gschueler gschueler

Labels
bug
Projects
None yet
Milestone
3.1.2
Development

Successfully merging a pull request may close this issue.

Fix #5301 fix initProject, and clean old listeners rundeck/rundeck
1 participant
@gschueler