Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CompanyInfo's minorversion to 3 #371

Open
drewish opened this issue Mar 31, 2017 · 2 comments
Open

Bump CompanyInfo's minorversion to 3 #371

drewish opened this issue Mar 31, 2017 · 2 comments

Comments

@drewish
Copy link
Contributor

drewish commented Mar 31, 2017

I spent a while wondering why the SubscriptionStatus didn't match what QBO showed on: https://developer.intuit.com/docs/0100_quickbooks_online/0100_essentials/000800_manage_your_apps/quickbooks_online_subscription_states

Then I found this in https://developer.intuit.com/docs/api/accounting/companyinfo
screen shot 2017-03-31 at 4 31 26 pm

And at that point, little hint "returned in the SubscriptionStatus attribute of the CompanyInfo resource (with query parameter minorversion=3)" made a lot more sense ;)

@minimul
Copy link
Collaborator

minimul commented Apr 7, 2017

Nice find. It is probably worth considering running with the latest minorversion globally by default. These minorversions usually just add new features so the chance of breakage is limited. There are fixes like with the Reports API in mv=3 (and other fixes) so users doing workarounds there might have breakage. Then again maybe there is not enough features in these minorversions to bother making the default.

@drewish
Copy link
Contributor Author

drewish commented Apr 7, 2017

Yeah might be worth moving the minor version code out of the Item service and into ServiceCrud where other classes could use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants