Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorybookJS v6 requires npm --legacy-peer-deps flag #132

Closed
maany opened this issue Feb 16, 2023 · 1 comment · Fixed by #133
Closed

StorybookJS v6 requires npm --legacy-peer-deps flag #132

maany opened this issue Feb 16, 2023 · 1 comment · Fixed by #133
Assignees
Labels
bug Something isn't working

Comments

@maany
Copy link
Member

maany commented Feb 16, 2023

Description

NPM v7+ installs peer dependencies by default; this is not the case with previous versions of NPM. NPM modules must name specific versions of their peer dependencies. If you already have a peer dependency installed, but not with a version named by the module, then NPM v7+ will throw an error. Adding --legacy-peer-deps ignores this new requirement, at the risk of introducing breaking changes

Obviously, we would like to avoid having non-pinned dependencies in the package-lock.json.

See storybookjs/storybook#18510 for details. This issue was fixed with the release of Storybook v7.

At the time of writing this, storybook v7.0.0 is in beta. Therefore, one option is to install the storybook beta release instead of using storybook v6

Steps to reproduce

  1. Clone the repo
  2. npm clean install

Rucio WebUI Version

master

Additional Information

No response

@maany maany added the bug Something isn't working label Feb 16, 2023
@maany maany changed the title StorybookJS requires npm --legacy-peer-deps flag StorybookJS v6 requires npm --legacy-peer-deps flag Feb 16, 2023
@maany maany linked a pull request Mar 2, 2023 that will close this issue
@maany
Copy link
Member Author

maany commented Mar 2, 2023

Fixed by migrating to Storybook v7 in #133

@maany maany closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants