Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant rse expression options in daemons #6766

Open
dynamic-entropy opened this issue May 8, 2024 · 1 comment
Open

Redundant rse expression options in daemons #6766

dynamic-entropy opened this issue May 8, 2024 · 1 comment
Assignees
Labels

Comments

@dynamic-entropy
Copy link
Contributor

Description

Few rucio-daemons take 3 rse_expression to decide on rses to work on. Namely exclude-rses, include-rses and rses.
This can now be reduced to 1, rses.

  --exclude-rses EXCLUDE_RSES
                        RSE expression to exclude
  --include-rses INCLUDE_RSES
                        RSE expression to include
  --rses RSES [RSES ...]
                        Explicit list of RSEs to include. If empty, it
                        considers all RSEs

The daemons are, reaper, dark-reaper, stager and submitter. (Please verify if there are more).

Note: Do not forget to update the documentation too.

Steps to reproduce

NA

Rucio Version

No response

Additional Information

No response

@dynamic-entropy
Copy link
Contributor Author

dynamic-entropy commented May 8, 2024

For daemons like dark-reaper the --rses argument requires a list of rses instead of a rse_expression.

File "/usr/local/lib/python3.9/site-packages/rucio/daemons/reaper/dark_reaper.py", line 235, in <listcomp>
invalid = set(rses) - set([rse['rse'] for rse in all_rses])                                                                                                                                            
TypeError: string indices must be integers  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants