Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: linter, add flake8-return #6729

Open
rdimaio opened this issue Apr 25, 2024 · 1 comment
Open

Testing: linter, add flake8-return #6729

rdimaio opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Apr 25, 2024

See: https://docs.astral.sh/ruff/rules/#flake8-return-ret

@rdimaio rdimaio self-assigned this Apr 25, 2024
@rdimaio
Copy link
Contributor Author

rdimaio commented Apr 25, 2024

There's a few rules here (like RET505: https://docs.astral.sh/ruff/rules/superfluous-else-return/) that I think should be first discussed with the other developers, as there's arguments on both sides. On one hand, as the else is superfluous, we should remove it to simplify the code; on the other hand, having the else might make the code more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant