Fix CI and try rbx-4 #399
Merged
Fix CI and try rbx-4 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xenial is now the default. Trusty is now out of support but still not end of life. Also omit the ruby patch versions so we don't have to keep updating them.
11 tasks
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xenial recently became the default
diston Travis, which broke the Java builds. Trusty has now reached end of Standard Support but not yet end of life.For more info on Java changes in Xenial: https://travis-ci.community/t/the-travis-ci-build-could-not-be-completed-due-to-an-error/1345
Also omit the ruby patch versions so we don't have to keep updating them.
The rubinius maintainer asked us to move from rbx-3 to rbx-4 in SIGSEGV from String#replace in rubyzip test suite rubinius/rubinius#3811, which is an easy change (on Trusty; on Xenial it doesn't appear to exist).
We had another apparently spurious drop in coverage in coveralls, but it still seems less flaky than it was before Update supported ruby versions #392 .
Edit: jruby 9.2 does not appear to work with JDK7, so I've held jruby at 9.1.
I'll leave this open for a bit for comment before merging it.