Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect timezone when reading timestamps from NTFS and UniversalTime extra fields? #571

Closed
hainesr opened this issue Mar 5, 2024 · 1 comment
Closed

Incorrect timezone when reading timestamps from NTFS and UniversalTime extra fields? #571

hainesr opened this issue Mar 5, 2024 · 1 comment
Assignees
@hainesr
Labels
bug
Milestone
3.0

Comments

@hainesr
Copy link
Member

hainesr commented Mar 5, 2024

When looking into #570 it appears that times are not read correctly from the NTFS and UniversalTime extra fields. These are supposed to be encoded in UTC, so when read back should have their timezone set as UTC so they can be correctly interpreted into the correct time for someone's local machine. At present it looks like they are being read as being in whatever the local timezone is.
@hainesr hainesr added the bug label Mar 5, 2024
@hainesr hainesr added this to the 3.0 milestone Mar 5, 2024
@hainesr hainesr self-assigned this Mar 5, 2024
@hainesr
Copy link
Member Author

hainesr commented Mar 6, 2024

Unix timestamps are always in UTC, so Time#at assumes UTC by default.

Not a bug then, thankfully.

@hainesr hainesr closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hainesr hainesr

Labels
bug
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@hainesr