IOExtras::AbstractOutputStream doesn't implement external_encoding

[dmolesUC]

With nokogiri 1.14.0 and rubyzip 2.3.2, running the code below fails with NoMethodError: undefined method 'external_encoding' for #<Zip::OutputStream:0x00000001241ec308>:

doc = Nokogiri::XML("<test/>")
Zip::OutputStream.open('test.zip') do |out|
  out.put_next_entry('test.xml')
  doc.write_to(out, encoding: 'UTF-8')
end

I'm not sure why Nokogiri calls external_encoding as as from the IO and Encoding docs external_encoding appears to be only for reading, but it also seems from the docs like just returning nil would be a legit implementation.

(Cf. sparklemotion/nokogiri#2773)

[hainesr]

Thanks for raising this. I've looked at the issue you link above and it looks like they have fixed things on their end, is that right?

[dmolesUC]

It looks like it's fixed in the latest Nokogiri, or will be shortly. Still wouldn't hurt to add a nil implementation, but it's your call.