Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the various occurrences of ftype consistent, and aligned to ::File.ftype #532

Open
hainesr opened this issue Jun 21, 2022 · 0 comments

Comments

@hainesr
Copy link
Member

hainesr commented Jun 21, 2022

This discussion started in #530 with @fbacall.

We should be consistent with ::File.ftype on what we return for entries in a Zip archive.

Notes:

  • ::File.ftype returns a string: 'file', 'directory' or 'link' (others, e.g. 'socket' aren't relevant for Zip files)
  • Zip::Entry.ftype returns a symbol: :file, :directory or :symlink
  • Zip::FileSystem::File.ftype returns a string, but returns 'file' if the entry is a symlink
  • Zip::FileSystem::File::Stat.ftype returns a string, and an error (Unknown file type) if the entry is a symlink
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant