Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip::FileSystem::ZipFsDir#glob triggers non-existing Zip::FileSystem::ZipFileNameMapper#glob method #356

Closed
AlexWayfer opened this issue Feb 28, 2018 · 2 comments · Fixed by #363

Comments

@AlexWayfer
Copy link

Code:

require 'zip'
require 'zip/filesystem'

Zip::File.open('archive.zip') do |zip_file|
  zip_file.dir.glob('flags/**/*')
end

Output:

NoMethodError: undefined method `glob' for #<Zip::FileSystem::ZipFileNameMapper:0x00005654bd818c98>
from /home/alex/.rbenv/versions/2.5.0/lib/ruby/gems/2.5.0/gems/rubyzip-1.2.1/lib/zip/filesystem.rb:475:in `glob'
@hainesr
Copy link
Member

hainesr commented Apr 30, 2018

Hi @AlexWayfer, I've had a go at fixing this. Does PR #363 do what you expect?

@AlexWayfer
Copy link
Author

Hello. Sorry, I don't remember. But I think yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants