Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protection Against Zip Bombs #193

Closed
schmijos opened this issue Nov 21, 2014 · 4 comments · Fixed by #403
Closed

Protection Against Zip Bombs #193

schmijos opened this issue Nov 21, 2014 · 4 comments · Fixed by #403

Comments

@schmijos
Copy link

Is there a way to protect against zip bombs? Are there limits where extraction is stopped? Can we configure limits? Can we do that at extraction-time by ourselves?

I cannot find anything about that in the documentation.

@simonoff
Copy link
Member

There is no such protections.

@radarek
Copy link

radarek commented Sep 15, 2016

What kind of protection would you expect? You can check size of each entry in zip file before unpacking. IMHO It should be sufficient but maybe you see problem here?

@schmijos
Copy link
Author

@radarek for the record from #403:

Currently there is no way to safely check how much data the Zip::Entry#extract method will actually extract, because the uncompressed size reported in the zip can be spoofed, and the extraction happens in the method where the caller can't check on its progress.

@jdleesmiller
Copy link
Member

^ And for the avoidance of doubt, "Currently" there means "before #403".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants