Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a Lint rule check for "2 different files: same ghsa: value, only 1 cve: value; Same advisory" #661

Open
jasnow opened this issue Jun 29, 2023 · 1 comment
Open

Write a Lint rule check for "2 different files: same ghsa: value, only 1 cve: value; Same advisory" #661

jasnow opened this issue Jun 29, 2023 · 1 comment

Comments

@jasnow
Copy link
Contributor

jasnow commented Jun 29, 2023 •
edited

Write a Lint rule check for "2 different files: same ghsa: value, only 1 cve: value" (currently not flagged)
1 file is named "CVE-*" (has cve: and ghsa: values) and 1 file is named "GHSA-" (no cve: value, but has ghsa: value).
@jasnow jasnow changed the title Lint rule check for "2 different files: same ghsa: value, only 1 cve: value; Same advisory" Write a Lint rule check for "2 different files: same ghsa: value, only 1 cve: value; Same advisory" Jun 29, 2023
@jasnow
Copy link
Contributor Author

jasnow commented Jul 11, 2023

Minimum test case:

  1. Run grep -v "^cve:" gems/bootstrap/*14040* > gems/bootstrap/GHSA-3wqf-4x89-9g79.yml
  2. Run "rake" and it will be green but you have two copies of the same advisory.

FYI: Verified today that PR #585 does not catch this condition.

@shaicoleman shaicoleman mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasnow