Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow passing Gemfile.lock paths to bundle audit #178

Closed
jsduke opened this issue Aug 30, 2017 · 6 comments · May be fixed by #224
Closed

allow passing Gemfile.lock paths to bundle audit #178

jsduke opened this issue Aug 30, 2017 · 6 comments · May be fixed by #224
Assignees
Labels

Comments

@jsduke
Copy link

jsduke commented Aug 30, 2017

either as a single file or as multiple files in the same command.

@postmodern postmodern self-assigned this Oct 12, 2017
@postmodern
Copy link
Member

Scanning multiple lock files is related to #181. Would definitely like to support that.

@ecbrodie
Copy link

@postmodern A situation where this could be useful is when I only want production-level gems to be checked and I want development gems to be excluded. I could maintain a Gemfile.lock file specific to just my production gems in my project, and point bundle-audit to it.

Although it's nice to be protected against all vulnerabilities, sometimes it is less urgent to resolve a vulnerability if it's just affecting a development gem. It allows CI pipelines that depend on a clean bundle-audit run to continue to be in a green state if only non-production gems are affected. For example, today's new vulnerability on rubyzip is disruptive to a project I'm involved with because a fix has not yet been published to rubygems. But, my project only depends on rubyzip through a gem used for unit tests only. Why must we now have our CI pipeline go into a RED state and cause disruption in our project?

@mallyvai
Copy link

mallyvai commented Dec 6, 2018

Going to +1 this - we would really appreciate this feature for CI purposes.

@dstull
Copy link

dstull commented Feb 18, 2019

+1 for same CI purposes

@postmodern
Copy link
Member

0.8.0 now supports a --gemfile-lock option and the command can accept a DIR argument.

@postmodern
Copy link
Member

bundler-audit 0.8.0.rc1 has been released! Please test and provide any QA feedback.

$ gem install --pre bundler-audit

kjeldahl added a commit to kjeldahl/bundler-audit that referenced this issue May 10, 2022
Pr. rubysec#178 the parameter is --gemfile-lock
postmodern pushed a commit that referenced this issue May 10, 2022
Pr. #178 the parameter is --gemfile-lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants