This repository has been archived by the owner on Aug 26, 2023. It is now read-only.
Register all global VALUES as mark objects #150
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was possible for these objects to be garbage collected (the constants could be unassigned in Ruby) or moved as part of GC compaction (reproducible with
GC.verify_compaction_references
).This commit marks all the global variables in
nokogumbo.c
usingrb_gc_register_mark_object
to ensure that they can't be moved.To test this, I added
GC.verify_compaction_references(toward: :empty, double_heap: true)
after the requires intest/test_nokogumbo.rb
. This guarantees that as many objects are moved as possible.Before
After