Use Nokogiri::XML::Node#line= to set the line number on nodes

[stevecheckoway]

If sparklemotion/nokogiri#1918 (or something like it) is accepted, then https://github.com/rubys/nokogumbo/blob/master/ext/nokogumbo/nokogumbo.c#L320 should be modified to use #line= if the node supports it.

This can be tested using rb_respond_to but apparently there's a bug on Ruby 2.3 https://bugs.ruby-lang.org/issues/12907 that causes that to always return true.

• Add Nokogiri::XML::Node#line= sparklemotion/nokogiri#1918 merged
• Nokogiri v1.11.0 (which should have #line=)
• Investigate the Ruby 2.3 issue (Ruby 2.3 EOL'd earlier this year so maybe it's fine to ignore this)
• Use #line= if the node supports it

[fulldecent]

Here is a way to do this on a branch #130 so effort can proceed.

[stevecheckoway]

I updated the issue with the list of steps that needs to happen. Looks like this should be resolved soon.

[flavorjones]

FWIW I'm planning to release Nokogiri v1.11.0 with #1918 by the end of December (to coincide with Ruby 2.7 release).

[stevecheckoway]

I kind of forgot about this issue. Is this worth doing pre-merge or is it better to wait?

[flavorjones]

🤣 I forgot to follow up, too. I think it probably makes sense to wait, since the current version of Nokogumbo will do the right thing if installed against a modern version of Nokogiri. But if you feel strongly about it, I won't object to shipping another Nokogumbo release with this change (we just won't port it into Nokogiri because we'll be compiling everything together going forward).

[stevecheckoway]

I think it makes sense to wait.

[flavorjones]

This has been upstreamed in Nokogiri v1.12.