BUG?: Bump mini_racer from 0.4.0 to 0.5.0 getting compile errors #220

bf4 · 2021-11-11T22:34:52Z

I see them in the GitHub Actions as well. Not sure exactly what caused it, but didn't see an existing issue so reporting

e.g. https://github.com/rubyjs/mini_racer/runs/4174922268?check_suite_focus=true

building against Ruby 2.7.2, heroku buildpack running on the heroku/heroku:18-build image and node 10.15.3

(
  export HEROKU_STACK="18"
  export ruby_version="2.7.2"
  echo "https://heroku-buildpack-ruby.s3.amazonaws.com/heroku-${HEROKU_STACK}/ruby-${ruby_version}.tgz"
  export node_version="10.15.3"
  echo "https://s3pository.heroku.com/node/v${node_version}/node-v${node_version}-linux-x64.tar.gz"

)

stacktrace from circleci

seems to be specific to libv8-node-15.14.0.0 -> libv8-node-16.10.0.0 requires I install node 16.13.0? (nope, that didn't work)

Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/root/server/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.5.0/ext/mini_racer_extension
/tmp/buildpack/ruby/ruby-2.7.2/bin/ruby -I
/tmp/buildpack/ruby/ruby-2.7.2/lib/ruby/2.7.0 -r
./siteconf20211111-3208-urf2xb.rb extconf.rb
checking for -lpthread... yes
creating Makefile

current directory:
/root/server/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.5.0/ext/mini_racer_extension
make "DESTDIR=" clean

current directory:
/root/server/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.5.0/ext/mini_racer_extension
make "DESTDIR="
compiling mini_racer_extension.cc
mini_racer_extension.cc: In function 'void* gvl_ruby_callback(void*)':
mini_racer_extension.cc:1255:92: warning: 'VALUE
ruby::backward::cxxanyargs::rb_rescue2(VALUE (*)(...), VALUE, VALUE (*)(...),
VALUE, ...)' is deprecated: Use of ANYARGS in this function is deprecated
[-Wdeprecated-declarations]
RUBY_METHOD_FUNC(rescue_callback), callback_data_value,
rb_eException, (VALUE)0);
^
In file included from
/tmp/buildpack/ruby/ruby-2.7.2/include/ruby-2.7.0/ruby/ruby.h:2863:0,
from
/tmp/buildpack/ruby/ruby-2.7.2/include/ruby-2.7.0/ruby.h:33,
                 from mini_racer_extension.cc:2:
/tmp/buildpack/ruby/ruby-2.7.2/include/ruby-2.7.0/ruby/backward/cxxanyargs.hpp:222:1:
note: declared here
 rb_rescue2(type *q, VALUE w, type *e, VALUE r, ...)
 ^~~~~~~~~~
linking shared-object mini_racer_extension.so
g++: error:
/root/server/vendor/bundle/ruby/2.7.0/gems/libv8-node-16.10.0.0-x86_64-linux-musl/vendor/v8/x86_64-linux/libv8/obj/libv8_monolith.a:
No such file or directory
Makefile:260: recipe for target 'mini_racer_extension.so' failed
make: *** [mini_racer_extension.so] Error 1

make failed, exit code 2

Gem files will remain installed in
/root/server/vendor/bundle/ruby/2.7.0/gems/mini_racer-0.5.0 for inspection.
Results logged to
/root/server/vendor/bundle/ruby/2.7.0/extensions/x86_64-linux/2.7.0/mini_racer-0.5.0/gem_make.out

An error occurred while installing mini_racer (0.5.0), and Bundler
cannot continue.
Make sure that `gem install mini_racer -v '0.5.0' --source

The text was updated successfully, but these errors were encountered:

tsugimoto · 2021-11-12T03:58:21Z

You're Fetching and Installing libv8-node 16.10.0.0 (x86_64-linux-musl), so I suppose it's likely a duplicate of #218

hmdne · 2021-11-14T07:05:58Z

Also got this. But maybe I have something to add: it only happens on Ruby 2.7 and 2.6, not on 3.0.

See: https://github.com/opal/opal/runs/4202357932

To avoid this: rubyjs/mini_racer#220

bf4 · 2021-11-15T16:59:01Z

@tsugimoto I saw #218 but since it's a different error, I wasn't confident it was the same issue, even if the result is the same. Thanks for cross-linking though

lloeki · 2021-11-16T12:34:58Z

Definitely looks like the same root cause, you can see things being mixed up here:

/root/server/vendor/bundle/ruby/2.7.0/gems/libv8-node-16.10.0.0-x86_64-linux-musl/vendor/v8/x86_64-linux/libv8/obj/libv8_monolith.a:

Also got this. But maybe I have something to add: it only happens on Ruby 2.7 and 2.6, not on 3.0.

With each Ruby version the vendored rubygems+bundler get updated. Can you update your rubygems+bundler and see if the issue persists?

hmdne · 2021-11-17T13:13:18Z

Thank you @lloeki. We were locking an outdated bundler version in our GitHub Actions due to an earlier issue with libv8. See: opal/opal#2360

dspaeth-lp · 2021-12-13T12:09:16Z

@lloeki

I got this error too. Steps to reproduce:

> docker run -ti  -w /usr/src/app --entrypoint /bin/sh ruby:2.7.4-alpine 
> apk update && apk add --no-cache build-base 
> gem update --system; gem install bundler
> bundle init
> echo "gem 'mini_racer', '0.5.0'" >> Gemfile 
> bundle

=> g++: error: /usr/local/bundle/gems/libv8-node-16.10.0.0-aarch64-linux/vendor/v8/aarch64-linux-musl/libv8/obj/libv8_monolith.a: No such file or directory

but it has to be

/usr/local/bundle/gems/libv8-node-16.10.0.0-aarch64-linux/vendor/v8/aarch64-linux/libv8/obj/libv8_monolith.a

aarch64-linux-musl => aarch64-linux

0.4.0 works

> docker run -ti  -w /usr/src/app --entrypoint /bin/sh ruby:2.7.4-alpine 
> apk update && apk add --no-cache build-base 
> gem update --system; gem install bundler
> bundle init
> echo "gem 'mini_racer', '0.4.0'" >> Gemfile 
> bundle

Edit: for libv8-node-15.14.0.1 the created lib is /usr/local/bundle/gems/libv8-node-15.14.0.1-aarch64-linux-musl/vendor/v8/out.gn/libv8/obj/libv8_monolith.a

rubyjs/mini_racer#220

lloeki · 2021-12-20T11:14:48Z

I'm going to try creating a fat gem which includes both linux and linux-musl libs (which I don't quite like since it doubles the gem size, but even when I get to fix the root rubygems/bundler issue old versions of these would still be affected)

rusterholz · 2022-01-06T16:46:50Z

Is there a fix for this? This is still happening with v0.6.0 as well.

ZimbiX · 2022-01-12T07:15:23Z

I think this may actually be a bug with the libv8-node gem instead, since installing that directly picks the musl version:

➜ gem install libv8-node              
Successfully installed libv8-node-16.10.0.0-x86_64-linux-musl
1 gem installed

I'm on Arch, which I don't think uses musl, and I haven't noticed musl in a gem install log before. That's not right, is it?

ZimbiX · 2022-01-12T07:31:15Z

Sorry, I should have read more of the context: rubyjs/libv8-node#5, rubygems/rubygems#3174. The bug lies in rubygems. A fix was merged (rubygems/rubygems#4082), with a second rubygems PR outstanding (rubygems/rubygems#4488).

Despite that second PR not being merged/released yet, simply updating rubygems allows me to successfully install the gem now: 🎉

➜ gem update --system  
[...]

➜ gem --version        
3.3.4     

➜ gem install libv8-node              
Successfully installed libv8-node-16.10.0.0-x86_64-linux
1 gem installed

➜ gem install mini_racer              
Building native extensions. This could take a while...
Successfully installed mini_racer-0.6.1
1 gem installed

Edit: Bundler still uses the wrong version - hence the second PR

wwahammy · 2022-01-18T16:19:19Z

@lloeki thanks so much for all the work you've done here. Like I asked on the other repo, is there anything I can do to help fix this? It's not fair to put all this on you but I'm not sure on what needs to be done or how I can help.

tisba · 2022-01-24T10:22:57Z

@bf4 can you check again against the latest mini_racer version? Also make sure to update rubygems and bundler.

A lot of related issues were solved by updating Rubygems and bundler and making sure the the right platforms are added to Gemfile.lock (via bundle lock --add-platform). From my understanding the outstanding rubygems issue/PR is about supporting multiple libc variants at the same time. So unless you need to support that in your projects, you should be good now.

lloeki · 2022-01-24T15:59:31Z

A lot of related issues were solved by updating Rubygems and bundler and making sure the the right platforms are added to Gemfile.lock (via bundle lock --add-platform)

Correct, but also, make sure to remove any platform-mismatched gem that may have been erroneously installed previously, otherwise bundler may be lazy and pick those up instead of hitting rubygems.org again. In some cases bundler was being stubborn and I've had to install the gem first with gem install, then proceed with bundle install.

From my understanding the outstanding rubygems issue/PR is about supporting multiple libc variants at the same time

It would indeed, but it should also helps in some corner cases e.g:

a) one created the lockfile on another platform than linux and did not run bundle lock --add-platform
b) one is on either linux (gnu) or linux-musl and the lockfile does not exist yet
c) a linux-musl gem on linux (gnu) cannot work, but could be picked up if it is previously installed for whatever reason

We have a dependabot/terraform PR problem: all the dependabot-triggered builds fail. A propos of rubyjs/mini_racer#220 (comment) ...update the rubygems and bundler that Docker (and hence CI) uses. Try this on its own first, then try `bundle lock --add-platform x86_64-linux`

It was surprisingly complicated to get an unpinned mini_racer. Mini_racer requires compilation, and this was failing on version 0.5.0 or higher. rubyjs/mini_racer#220 appears relevant, and gives hints about updating bundler and rubygems (we also updated the hard-coded rake in the Dockerfile for good measure). After recreating the Gemfile.lock from scratch (because bundler will automatically install and run the version of bundler from the Gemfile.lock file) it still didn't work, but told us to run `bundle lock --add-platform x86_64-linux` which made it successfully work. This is probably of use to other projects struggling to upgrade mini_racer.

schneems · 2022-02-07T18:21:34Z

This isn't a bug in mini racer or in Heroku. This is a bug in bundler.

Make sure you run:

bundle lock --add-platform x86_64-linux

Then add the results to git before you try to deploy again. Previously bundler would raise an error if you tried deploying to a linux target without the linux platform locked. It looks like there's been a regression and that error is no longer raised. If that error still existed it would prevent this problem from happening as it wouldn't even let you try to bundle install without the correct platform being listed.

tisba · 2022-02-13T15:08:24Z

I've added a PR to add an installation troubleshooting section to the README: #240.

wanlinwang · 2022-08-17T13:12:05Z

gem install mini_racer

Sorry, I should have read more of the context: rubyjs/libv8-node#5, rubygems/rubygems#3174. The bug lies in rubygems. A fix was merged (rubygems/rubygems#4082), with a second rubygems PR outstanding (rubygems/rubygems#4488).

Despite that second PR not being merged/released yet, simply updating rubygems allows me to successfully install the gem now: 🎉
➜ gem update --system  
[...]

➜ gem --version        
3.3.4     

➜ gem install libv8-node              
Successfully installed libv8-node-16.10.0.0-x86_64-linux
1 gem installed

➜ gem install mini_racer              
Building native extensions. This could take a while...
Successfully installed mini_racer-0.6.1
1 gem installed
Edit: Bundler still uses the wrong version - hence the second PR

Thank you. It works.

evolve2k · 2023-01-13T04:37:09Z

Workaround. Resolved by upgrading from ruby 2.7 to ruby 3.0

phosei added a commit to phosei/wink that referenced this issue Nov 15, 2021

Gemfile: Limit version of mini_racer

242e6ed

To avoid this: rubyjs/mini_racer#220

phosei added a commit to phosei/wink that referenced this issue Nov 15, 2021

Limit version of mini_racer

299e5a0

To avoid this: rubyjs/mini_racer#220

ryantk mentioned this issue Nov 17, 2021

Bump mini_racer from 0.4.0 to 0.5.0 DFE-Digital/buy-for-your-school#655

Closed

antw added a commit to quintel/etcentral that referenced this issue Dec 15, 2021

Downgrade mini_racer to 0.4

6eb69cc

rubyjs/mini_racer#220

lloeki mentioned this issue Dec 20, 2021

0.5.0.pre fails to install/build on Github Actions (Ruby 3.0.1) #218

Closed

brendanshean mentioned this issue Jan 20, 2022

Remove therubyracer gem empirical-org/Empirical-Core#8706

Merged

dragon-dxw mentioned this issue Jan 24, 2022

Bundle update, pinning mini_racer to 0.4.0 UKGovernmentBEIS/beis-report-official-development-assistance#1539

Closed

rgarner mentioned this issue Jan 25, 2022

Upgrade bundler & rubygems for terraform/dependabot issue UKGovernmentBEIS/beis-report-official-development-assistance#1543

Closed

4 tasks

tisba closed this as completed Feb 13, 2022

jtannas mentioned this issue Aug 28, 2022

drop support for EOL ruby + rails versions rswag/rswag#542

Merged

jtannas added a commit to rswag/rswag that referenced this issue Aug 28, 2022

https://github.com/rubyjs/mini_racer/issues/220#issuecomment-1010724771

4096084

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG?: Bump mini_racer from 0.4.0 to 0.5.0 getting compile errors #220

BUG?: Bump mini_racer from 0.4.0 to 0.5.0 getting compile errors #220

bf4 commented Nov 11, 2021 •

edited

tsugimoto commented Nov 12, 2021

hmdne commented Nov 14, 2021

bf4 commented Nov 15, 2021

lloeki commented Nov 16, 2021

hmdne commented Nov 17, 2021

dspaeth-lp commented Dec 13, 2021 •

edited

lloeki commented Dec 20, 2021

rusterholz commented Jan 6, 2022

ZimbiX commented Jan 12, 2022

ZimbiX commented Jan 12, 2022 •

edited

wwahammy commented Jan 18, 2022

tisba commented Jan 24, 2022

lloeki commented Jan 24, 2022

schneems commented Feb 7, 2022

tisba commented Feb 13, 2022

wanlinwang commented Aug 17, 2022

evolve2k commented Jan 13, 2023

BUG?: Bump mini_racer from 0.4.0 to 0.5.0 getting compile errors #220

BUG?: Bump mini_racer from 0.4.0 to 0.5.0 getting compile errors #220

Comments

bf4 commented Nov 11, 2021 • edited

tsugimoto commented Nov 12, 2021

hmdne commented Nov 14, 2021

bf4 commented Nov 15, 2021

lloeki commented Nov 16, 2021

hmdne commented Nov 17, 2021

dspaeth-lp commented Dec 13, 2021 • edited

lloeki commented Dec 20, 2021

rusterholz commented Jan 6, 2022

ZimbiX commented Jan 12, 2022

ZimbiX commented Jan 12, 2022 • edited

wwahammy commented Jan 18, 2022

tisba commented Jan 24, 2022

lloeki commented Jan 24, 2022

schneems commented Feb 7, 2022

tisba commented Feb 13, 2022

wanlinwang commented Aug 17, 2022

evolve2k commented Jan 13, 2023

bf4 commented Nov 11, 2021 •

edited

dspaeth-lp commented Dec 13, 2021 •

edited

ZimbiX commented Jan 12, 2022 •

edited