Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate V8_ASSUME_ALIGNED warning on macOS #13

Open
lloeki opened this issue Nov 4, 2020 · 0 comments
Open

Investigate V8_ASSUME_ALIGNED warning on macOS #13

lloeki opened this issue Nov 4, 2020 · 0 comments

Comments

@lloeki
Copy link
Collaborator

lloeki commented Nov 4, 2020

Has no apparent functional effect on result: mini_racer tests still pass with about the same performance.

Started when building the newly added gyp target libv8_monolith instead of node.

In file included from ../deps/v8/src/compiler/compilation-dependencies.cc:10:
2272
In file included from ../deps/v8/src/objects/allocation-site-inl.h:10:
2273
In file included from ../deps/v8/src/heap/heap-write-barrier-inl.h:15:
2274
In file included from ../deps/v8/src/objects/compressed-slots-inl.h:10:
2275
../deps/v8/src/common/ptr-compr-inl.h:43:44: warning: requested alignment must be 536870912 bytes or smaller; maximum alignment assumed [-Wbuiltin-assume-aligned-alignment]
2276
  isolate_root = reinterpret_cast<Address>(V8_ASSUME_ALIGNED(
2277
                                           ^~~~~~~~~~~~~~~~~~
2278
../deps/v8/include/v8config.h:364:3: note: expanded from macro 'V8_ASSUME_ALIGNED'
2279
  __builtin_assume_aligned((ptr), (alignment))
2280
  ^                               ~~~~~~~~~~~
@lloeki lloeki changed the title Investigate Investigate V8_ASSUME_ALIGNED warning on macOS Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant