Fix Bundler::Plugin::API::Source#to_s having empty source type
#4084
Conversation
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
| @@ -260,7 +260,7 @@ def to_lock | |||
| end | |||
|
|
|||
| def to_s | |||
| "plugin source for #{options[:type]} with uri #{uri}" | |||
| "plugin source for #{@type} with uri #{@uri}" | |||
There was a problem hiding this comment.
Use instance variables to be consistent with #to_lock implementation.
deivid-rodriguez
changed the title
Bundler::Plugin::API::Source#to_s having empty source type
Fix `Bundler::Plugin::API::Source#to_s` having empty source type (cherry picked from commit f38872c)
Fix `Bundler::Plugin::API::Source#to_s` having empty source type (cherry picked from commit f38872c)
Fix `Bundler::Plugin::API::Source#to_s` having empty source type (cherry picked from commit f38872c)
Fix `Bundler::Plugin::API::Source#to_s` having empty source type (cherry picked from commit f38872c)
What was the end-user or developer problem that led to this PR?
I found this small bug during developing bundler plugin.
What is your fix for the problem, implemented in this PR?
The fix is self explanatory and covered with spec.
Make sure the following tasks are checked
Write code to solve the problem