New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New gem template: prefer require_relative
to require
#4066
Conversation
Mmm, that's incorrect in case of |
8a05fa1
to
74ca9ae
Compare
Should be fixed, tests too 😅 |
74ca9ae
to
45d084e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcandre!
New gem template: prefer `require_relative` to `require` (cherry picked from commit 13bce26)
New gem template: prefer `require_relative` to `require` (cherry picked from commit 13bce26)
New gem template: prefer `require_relative` to `require` (cherry picked from commit 13bce26)
New gem template: prefer `require_relative` to `require` (cherry picked from commit 13bce26)
@deivid-rodriguez Can you give some info about the benefits of using The PR description mentions that it is to bring things in line with the Should I would appreciate any feedback so I can adapt to newer/better practices if needed. |
Hello! My personal recommendation is to use |
@deivid-rodriguez That makes sense - thanks a lot for the quick response. I will use this strategy in future. Have a nice Christmas ! |
New gem template uses
require_relative
in the gemspec butrequire
in thelib/gem.rb
. This PR changes that second occurrence.