Always show underlying error when fetching specs fails #4061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`OpenSSL::SSL::SSLError` and `Net::HTTPFatalError` should never be raised here.
The one that failed to be fetched.
deivid-rodriguez
force-pushed
the
better_http_errors
branch
from
dc00448
to
954c543
Compare
4 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Always show underlying error when fetching specs fails (cherry picked from commit 1fa4ee3)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Always show underlying error when fetching specs fails (cherry picked from commit 1fa4ee3)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Always show underlying error when fetching specs fails (cherry picked from commit 1fa4ee3)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Always show underlying error when fetching specs fails (cherry picked from commit 1fa4ee3)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When network failures happen, errors could be more helpful.
What is your fix for the problem, implemented in this PR?
Include the underlying network error in the default output.
Fixes #3805.
Make sure he following tasks are checked