Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra empty line from README template #4041

Merged
merged 1 commit into from Oct 28, 2020

Conversation

r7kamura
Copy link
Contributor

What was the end-user or developer problem that led to this PR?

bundle gem my_gem --mit generates README.md that contains extra empty line like this:

## Contributing

Bug reports and pull requests are welcome on GitHub at https://github.com/r7kamura/my_gem.


## License

The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

What is your fix for the problem, implemented in this PR?

Removed an empty line placed before the License section from README template (README.md.tt).

Make sure he following tasks are checked

@welcome
Copy link

welcome bot commented Oct 27, 2020

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hsbt hsbt merged commit cb1b51f into rubygems:master Oct 28, 2020
@r7kamura r7kamura deleted the feature/readme-empty-lines branch October 28, 2020 11:20
deivid-rodriguez pushed a commit that referenced this pull request Dec 7, 2020
Remove extra empty line from README template

(cherry picked from commit cb1b51f)
deivid-rodriguez pushed a commit that referenced this pull request Dec 7, 2020
Remove extra empty line from README template

(cherry picked from commit cb1b51f)
deivid-rodriguez pushed a commit that referenced this pull request Dec 7, 2020
Remove extra empty line from README template

(cherry picked from commit cb1b51f)
deivid-rodriguez pushed a commit that referenced this pull request Dec 7, 2020
Remove extra empty line from README template

(cherry picked from commit cb1b51f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants