Fix incorrect error message on Windows #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're parsing the exception message here looking for a path, but we were not considering potential drive letters on Windows.
deivid-rodriguez
force-pushed
the
fix_incorrect_error_message_on_windows
branch
from
001fede
to
512bb01
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…_windows Fix incorrect error message on Windows (cherry picked from commit 7d20043)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…_windows Fix incorrect error message on Windows (cherry picked from commit 7d20043)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…_windows Fix incorrect error message on Windows (cherry picked from commit 7d20043)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…_windows Fix incorrect error message on Windows (cherry picked from commit 7d20043)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
We're parsing the exception message here looking for a path, but we were not considering potential drive letters on Windows. So we were showing an invalid path in the final error.
What is your fix for the problem, implemented in this PR?
Add an optional part to the regexp to also capture the drive letter.
Make sure he following tasks are checked