Enable specific_platform by default
#4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
specific_platform_by_default
branch
2 times, most recently
from
66ec766
to
d3bc288
Compare
deivid-rodriguez
force-pushed
the
specific_platform_by_default
branch
from
93a5306
to
9f8c907
Compare
deivid-rodriguez
force-pushed
the
specific_platform_by_default
branch
from
9f8c907
to
3ad1285
Compare
To properly support gems providing native platform versions with different dependencies than their pure ruby counterparts. Nokogiri will start doing this soon. In particular, for each version, the pure ruby variant will not have a `required_ruby_version` upper bound, but the native variant will. Bundler should always install a valid bundle in this case.
With specific platforms by default, it sounds like we can fix a previous "duplicated spec groups" issue by calling uniq on the array of definition platforms.
deivid-rodriguez
force-pushed
the
specific_platform_by_default
branch
from
3ad1285
to
91cfcfe
Compare
|
Let's do this! |
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Enable `specific_platform` by default (cherry picked from commit 824f272)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Enable `specific_platform` by default (cherry picked from commit 824f272)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Enable `specific_platform` by default (cherry picked from commit 824f272)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Enable `specific_platform` by default (cherry picked from commit 824f272)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To properly support gems providing native platform versions with different dependencies than their pure ruby counterparts.
Nokogiri will start doing this soon. In particular, for each version, the pure ruby variant will not have a
required_ruby_versionupper bound, but the native variant will. Bundler should always install a valid bundle in this case.Closes #3200.
Closes #4012.
Make sure he following tasks are checked