Move ronn pages to lib #3997
Merged
Move ronn pages to lib #3997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
better_man
branch
2 times, most recently
from
0d93254
to
c51f6c9
Compare
It was overly complicated for no reason.
Since they will have different logic afterwards.
Only need to consider them for removing old versions.
deivid-rodriguez
force-pushed
the
better_man
branch
from
c51f6c9
to
8e20455
Compare
The inverse counterargument could also be applied to lib: |
|
@hsbt Without having looked at the specific failures, due to the tests you had to revert in ruby/ruby#3659, I believe it's very likely that this PR will fix that problem. |
hsbt
approved these changes
Oct 15, 2020
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Move ronn pages to lib (cherry picked from commit 59fa4e6)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Move ronn pages to lib (cherry picked from commit 59fa4e6)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Move ronn pages to lib (cherry picked from commit 59fa4e6)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Move ronn pages to lib (cherry picked from commit 59fa4e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The problem is that under the following conditions:
Bundler would crash.
The problem is that if
manis not available, bundler will fallback to displaying to.ronnplain text sources of the man pages. However, if bundler was installed as a default gem by ruby-core installer, those.ronnsources are not installed toRbConfig::CONFIG["mandir"].What is your fix for the problem, implemented in this PR?
My fix, instead of artifically installing
.ronnsources toman1orman5folders (which rubygems installer was currently doing), is to keep.ronnsources insidelib. That way, we can always find them no matter which type of bundler installation we're running.The alternative was to change ruby-core installer to also install
.ronnsources toRbConfig::CONFIG["mandir"] + "man1"andRbConfig::CONFIG["mandir"] + "man5", but I found weird that we were doing that in the first place, since it seems to me that theman1andman5folders are only supposed to hold.1and.5files, respectively.Fixes #3996.
Make sure he following tasks are checked