Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn when deinit'ing submodules #3969

Merged
merged 1 commit into from Oct 1, 2020
Merged

Conversation

deivid-rodriguez
Copy link
Member

Fixes #3293.

Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@deivid-rodriguez deivid-rodriguez merged commit 73ba6e1 into master Oct 1, 2020
@deivid-rodriguez deivid-rodriguez deleted the no_deinit_warn branch October 1, 2020 11:01
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Don't warn when deinit'ing submodules

(cherry picked from commit 73ba6e1)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Don't warn when deinit'ing submodules

(cherry picked from commit 73ba6e1)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Don't warn when deinit'ing submodules

(cherry picked from commit 73ba6e1)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Don't warn when deinit'ing submodules

(cherry picked from commit 73ba6e1)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Don't warn when deinit'ing submodules

(cherry picked from commit 73ba6e1)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Don't warn when deinit'ing submodules

(cherry picked from commit 73ba6e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noisy warnings from submodule deinit on git >= 2.21.0
2 participants