New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore bundle cache --all
in all cases
#3914
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
restore_package_all_flag
branch
3 times, most recently
from
August 29, 2020 09:30
36a127a
to
6f83fe4
Compare
deivid-rodriguez
changed the title
Restore
Restore Aug 29, 2020
bundle cache --all
in all cases, and deprecate itbundle cache --all
in all cases
I'll split the deprecation to a separate PR, since the bug fix and the deprecation are different tasks, and should appear in different changelog sections. |
This was referenced Sep 2, 2020
This reverts commit 713d906. We should deprecate it rather the remove it abruptly.
deivid-rodriguez
force-pushed
the
restore_package_all_flag
branch
from
September 5, 2020 16:53
6f83fe4
to
49f0636
Compare
4 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Restore `bundle cache --all` in all cases (cherry picked from commit 5be5e29)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Restore `bundle cache --all` in all cases (cherry picked from commit 5be5e29)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Restore `bundle cache --all` in all cases (cherry picked from commit 5be5e29)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Restore `bundle cache --all` in all cases (cherry picked from commit 5be5e29)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Restore `bundle cache --all` in all cases (cherry picked from commit 5be5e29)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Restore `bundle cache --all` in all cases (cherry picked from commit 5be5e29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The
bundle cache --all
flag has been going back and forth recently, since I'm not too clear what our plan on it is.The current situation, where
bundle cache --all
only works the first time it's run is definitely not what we want.My proposal is to restore the flag, but deprecate it. The rationale is the same for all the other flags that are silently rememebered. Instead, recommend users to use configuration, and set
bundle config cache_all true
if they want git and path gems to also be cached.The change in the default value of
cache_all
set for bundler 3 (where path and git gems will be cached by default) is kept.Fixes #3598.
Tasks:
I will abide by the code of conduct.