Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore bundle cache --all in all cases #3914

Merged
merged 2 commits into from Sep 6, 2020

Conversation

deivid-rodriguez
Copy link
Member

Description:

The bundle cache --all flag has been going back and forth recently, since I'm not too clear what our plan on it is.

The current situation, where bundle cache --all only works the first time it's run is definitely not what we want.

My proposal is to restore the flag, but deprecate it. The rationale is the same for all the other flags that are silently rememebered. Instead, recommend users to use configuration, and set bundle config cache_all true if they want git and path gems to also be cached.

The change in the default value of cache_all set for bundler 3 (where path and git gems will be cached by default) is kept.

Fixes #3598.


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

@deivid-rodriguez deivid-rodriguez force-pushed the restore_package_all_flag branch 3 times, most recently from 36a127a to 6f83fe4 Compare August 29, 2020 09:30
@deivid-rodriguez deivid-rodriguez changed the title Restore bundle cache --all in all cases, and deprecate it Restore bundle cache --all in all cases Aug 29, 2020
@deivid-rodriguez
Copy link
Member Author

I'll split the deprecation to a separate PR, since the bug fix and the deprecation are different tasks, and should appear in different changelog sections.

This reverts commit 713d906.

We should deprecate it rather the remove it abruptly.
@deivid-rodriguez deivid-rodriguez merged commit 5be5e29 into master Sep 6, 2020
@deivid-rodriguez deivid-rodriguez deleted the restore_package_all_flag branch September 6, 2020 10:08
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Restore `bundle cache --all` in all cases

(cherry picked from commit 5be5e29)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Restore `bundle cache --all` in all cases

(cherry picked from commit 5be5e29)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Restore `bundle cache --all` in all cases

(cherry picked from commit 5be5e29)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Restore `bundle cache --all` in all cases

(cherry picked from commit 5be5e29)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Restore `bundle cache --all` in all cases

(cherry picked from commit 5be5e29)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Restore `bundle cache --all` in all cases

(cherry picked from commit 5be5e29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bundle package --all fails if BUNDLE_CACHE_ALL is set to true in .bundle/config
2 participants