Fix ls-files matching regexp #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As splitting by NUL means to allow the file names to contain newlines, path names should match at beginning-of-string instead of beginning-of-line.
deivid-rodriguez
added
rubygems: minor enhancement
and removed
rubygems: minor enhancement
labels
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 5, 2020
Fix ls-files matching regexp (cherry picked from commit 97ebb3f)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 5, 2020
Fix ls-files matching regexp (cherry picked from commit 97ebb3f)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 5, 2020
Fix ls-files matching regexp (cherry picked from commit 97ebb3f)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 6, 2020
Fix ls-files matching regexp (cherry picked from commit 97ebb3f)
deivid-rodriguez
added
bundler: enhancement
and removed
bundler: minor enhancement
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
As splitting by NUL means to allow the file names to contain newlines, path names should match at beginning-of-string instead of beginning-of-line.
What was the end-user or developer problem that led to this PR?
Nothing.
Sane programmers never use newline in pathnames.
What is your fix for the problem, implemented in this PR?
Match by
\Ainstead of^.Also made a regexp group uncaptured.
Tasks:
I will abide by the code of conduct.