Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant bundler/setup require from spec_helper.rb generated by bundle gem #3791

Merged
merged 1 commit into from Jul 6, 2020

Conversation

utkarsh2102
Copy link
Contributor

Having "bundler/setup" in spec_helper doesn't make
much sense. On the other hand, it becomes a problem
for downstream as they constantly have to keep patching
this from all the libraries.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

Having "bundler/setup" in spec_helper doesn't make
much sense. On the other hand, it becomes a problem
for downstream as they constantly have to keep patching
this from all the libraries.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

I you run bundle exec rspec, it's redundant. If on the other hand you run rspec, it might be too late and the wrong version might be already activated.

@deivid-rodriguez
Copy link
Member

Thanks @utkarsh2102!!

@deivid-rodriguez deivid-rodriguez merged commit a0658a9 into rubygems:master Jul 6, 2020
@utkarsh2102 utkarsh2102 deleted the drop-bundler-setup branch July 7, 2020 17:49
@deivid-rodriguez deivid-rodriguez changed the title Remove redundant "bundler/setup" Remove redundant bundler/setup require from spec_helper.rb generated by bundle gem Jul 15, 2020
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Remove redundant "bundler/setup"

(cherry picked from commit a0658a9)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Remove redundant "bundler/setup"

(cherry picked from commit a0658a9)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Remove redundant "bundler/setup"

(cherry picked from commit a0658a9)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Remove redundant "bundler/setup"

(cherry picked from commit a0658a9)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Remove redundant "bundler/setup"

(cherry picked from commit a0658a9)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Remove redundant "bundler/setup"

(cherry picked from commit a0658a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants