New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant bundler/setup
require from spec_helper.rb
generated by bundle gem
#3791
Merged
deivid-rodriguez
merged 1 commit into
rubygems:master
from
utkarsh2102:drop-bundler-setup
Jul 6, 2020
Merged
Remove redundant bundler/setup
require from spec_helper.rb
generated by bundle gem
#3791
deivid-rodriguez
merged 1 commit into
rubygems:master
from
utkarsh2102:drop-bundler-setup
Jul 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having "bundler/setup" in spec_helper doesn't make much sense. On the other hand, it becomes a problem for downstream as they constantly have to keep patching this from all the libraries. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
deivid-rodriguez
approved these changes
Jul 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed!
I you run bundle exec rspec
, it's redundant. If on the other hand you run rspec
, it might be too late and the wrong version might be already activated.
colby-swandale
approved these changes
Jul 6, 2020
Thanks @utkarsh2102!! |
deivid-rodriguez
changed the title
Remove redundant "bundler/setup"
Remove redundant Jul 15, 2020
bundler/setup
require from spec_helper.rb
generated by bundle gem
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Remove redundant "bundler/setup" (cherry picked from commit a0658a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Remove redundant "bundler/setup" (cherry picked from commit a0658a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Remove redundant "bundler/setup" (cherry picked from commit a0658a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Remove redundant "bundler/setup" (cherry picked from commit a0658a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Remove redundant "bundler/setup" (cherry picked from commit a0658a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Remove redundant "bundler/setup" (cherry picked from commit a0658a9)
deivid-rodriguez
added
bundler: enhancement
and removed
bundler: minor enhancement
labels
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having "bundler/setup" in spec_helper doesn't make
much sense. On the other hand, it becomes a problem
for downstream as they constantly have to keep patching
this from all the libraries.
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
Tasks:
I will abide by the code of conduct.