New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle keep "installing" plugins from Gemfile #6630
Comments
Hello @dfop02! Thanks for the report. I can reproduce the problem. Would you mind to open PR with your suggested solution? It would be needed to add also some specs to ensure this is not going to regress again. I can help you in PR if needed. Feel free to inspire at other related specs at https://github.com/rubygems/rubygems/blob/63bfffea48182490f307c42bade849a584d10a7e/bundler/spec/bundler/plugin_spec.rb. Btw. you linked |
Hello @simi , I opened a PR for this issue, please take a look when you had some time. |
Hello, Any update on this? It still happening for me in |
Describe the problem as clearly as you can
I started building a very simple plugin using as reference this guide, after push and test I notice that when we bundle install them from Gemfile (without git or path), it keep saying "installing" every run.
Did you try upgrading rubygems & bundler?
Yes, I tested on Bundler 2.4.12 and Rubygems 3.4.12
Post steps to reproduce the problem
Just add any plugin to your Rails App gemfile as specified on the early guide, ex.:
Gemfile
Which command did you run?
bundle
orbundle install
What were you expecting to happen?
plugins are already installed, but the bundler tries install again
What actually happened?
"Installing plugin x" even if is already installed
Where is the problem?
I did a small search and found the problem probably here where Bundler keep installing plugins if they're already installed, what makes the bug.
How solve the problem?
I actually tried few changes on my own version of Bundler gem 2.4.12, looks very simple to fix but since I don't know if could have any impact, prefer wait you guys to take a look. I solved the problem just checking if there is plugins not installed yet before actually install someone, here:
bundler/plugin.rb#L88
Please take a look and say if makes sense :)
If not included with the output of your command, run
bundle env
and paste the output belowThe text was updated successfully, but these errors were encountered: