Fix test failure when version is exactly 3.2 #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the stable branch (when version is exactly 3.2), this test fails because rubygems updater aborts early in the specific case when we are upgrading to the exact same rubygems version being run with an "already installed" message. To fix this problem, I change the test to use the earliest possible 3.2 prerelease, which is the same version that shipped the new layout and it's a past release so it should pass consistently no matter when the running rubygems release is.
deivid-rodriguez
deleted the
fix_test_failure_when_version_is_exactly_3_2
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…is_exactly_3_2 Fix test failure when version is exactly 3.2 (cherry picked from commit e5c214d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In the stable branch (when version is exactly 3.2), this test fails because rubygems updater aborts early in the specific case when we are upgrading to the exact same rubygems version being run with an "already installed" message.
What is your fix for the problem, implemented in this PR?
To fix this problem, I change the test to use the earliest possible 3.2 prerelease, which is the same version that shipped the new layout and it's a past release so it should pass consistently no matter when the running rubygems release is.
Make sure the following tasks are checked