New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation messages recommending bundle config
don't have the same effect as the old persisted flags
#3916
Comments
I agree, we should fix the deprecation messages and consider changing |
…d be --local as before * See rubygems#3916 * Always show --local or --global for `bundle config set` commands as the default is global which can be not intuitive (rubygems#3916).
PR to fix the deprecation messages and always show |
cc @chrisseaton since you ran into this bug (but I'm sure you're not the only one, this exists since Bundler 2 IIRC). |
…d be --local as before * See rubygems#3916 * Always show --local or --global for `bundle config set` commands as the default is global which can be not intuitive (rubygems#3916).
…d be --local as before * See rubygems#3916 * Always show --local or --global for `bundle config set` commands as the default is global which can be not intuitive (rubygems#3916).
…d be --local as before * See rubygems#3916 * Always show --local or --global for `bundle config set` commands as the default is global which can be not intuitive (rubygems#3916).
…d be --local as before * See rubygems#3916 * Always show --local or --global for `bundle config set` commands as the default is global which can be not intuitive (rubygems#3916).
Could we reopen to track changing the default? Or should I file a new issue? |
I prefer a new ticket referencing this one. |
OK, #3926 |
bundle config
does not have the same effect as the old persisted flags
bundle config
does not have the same effect as the old persisted flagsbundle config
don't have the same effect as the old persisted flags
Thanks, I also edited the title of this ticket to reflect what we fixed in the PR that closed this. |
Describe the problem as clearly as you can
bundle config key value
is--global
by default (stored in~/.bundle/config
), while I think most usages would benefit from being local.For instance, typical mistakes are
bundle config path vendor/bundle
,bundle config without db
, etc.Which unfortunately is also what is shown by deprecation messages, and I believe that part is an outright bug (Bundler 2.1.4) because the old flags did write to
.bundle/config
(=--local
), fixed by #3917:Note also that the very similar command
git config key value
defaults to--local
.I think it would be much safer and intuitive to change
bundle config key value
to also default to--local
.Most of Bundler configuration is project-specific and doing it globally makes often little sense, especially when not stating explicitly one wants it to be global.
The text was updated successfully, but these errors were encountered: