bundle add should update vendor/cache
#3309
Labels
Comments
ghost
referenced
this issue
in rubygems/bundler
Nov 6, 2019
7393: Make 'bundle add' cache newly added gems when needed r=deivid-rodriguez a=andrehjr ### What was the end-user problem that led to this PR? The problem was that when calling `bundle add` with cache_all as true, I have to call an additional `bundle install` to vendor gems. ### What was your diagnosis of the problem? My diagnosis was that a call to Bundler.load.cache was missing. For example Bundler::CLI::Update does the same after installing gems. ### What is your fix for the problem, implemented in this PR? My fix was to call Bundler.load.cache when `Bundler.app_cache.exist? ` ### Why did you choose this fix out of the possible options? I chose this fix because it looks like this makes the behavior consistent with other commands. I should also say that, as this is my first PR here, I'm not sure that this is the best solution, and it seems an easy fix for #7384. Co-authored-by: André Luis Leal Cardoso Junior <andrehjr@gmail.com>
deivid-rodriguez
referenced
this issue
in rubygems/bundler
Nov 7, 2019
7393: Make 'bundle add' cache newly added gems when needed r=deivid-rodriguez a=andrehjr ### What was the end-user problem that led to this PR? The problem was that when calling `bundle add` with cache_all as true, I have to call an additional `bundle install` to vendor gems. ### What was your diagnosis of the problem? My diagnosis was that a call to Bundler.load.cache was missing. For example Bundler::CLI::Update does the same after installing gems. ### What is your fix for the problem, implemented in this PR? My fix was to call Bundler.load.cache when `Bundler.app_cache.exist? ` ### Why did you choose this fix out of the possible options? I chose this fix because it looks like this makes the behavior consistent with other commands. I should also say that, as this is my first PR here, I'm not sure that this is the best solution, and it seems an easy fix for #7384. Co-authored-by: André Luis Leal Cardoso Junior <andrehjr@gmail.com> (cherry picked from commit f83412a)
|
This was fixed by rubygems/bundler#7393, but never closed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I have previously vendored gems using
bundle package, and I thenbundle adda new gem, the new gem is not cached invendor/cache. I'd expectbundle addto cache the new gem, because if I manually add the gem to the Gemfile andbundle install, it is cached.Using bundler 2.0.1, Ruby 2.4.2
Thanks for considering this issue!
The text was updated successfully, but these errors were encountered: