Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two circular require warnings from test suite #2548

Closed
1 of 5 tasks
MSP-Greg opened this issue Dec 23, 2018 · 7 comments
Closed
1 of 5 tasks

Two circular require warnings from test suite #2548

MSP-Greg opened this issue Dec 23, 2018 · 7 comments

Comments

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Dec 23, 2018

Using ruby 2.6.0dev (2018-12-24 trunk 66515) [x64-mingw32]

and

rake test RUBYOPT=--verbose TEST=test/rubygems/test_gem.rb TESTOPTS=-v

warning: loading in progress, circular require considered harmful occurs during:

TestGem#test_looks_for_gemdeps_files_automatically_on_start
TestGem#test_looks_for_gemdeps_files_automatically_on_start_in_parent_dir

I'd check on Travis with Ubuntu & MacOS, but I can't because of Issue #2451...

This issue is related to:

  • Network problems
  • Installing a library
  • Publishing a library
  • The command line gem
  • Other

Here are my current environment details:

trunk & master

I will abide by the code of conduct.

@bronzdoc
Copy link
Member

Just tested this in Ubuntu(Ubuntu 18.04.1 LTS) and MacOS(Mojave) and the warning is happening in both systems...

@MSP-Greg
Copy link
Contributor Author

I still see this everyday with the trunk build on ruby-loco. For Travis see:
https://travis-ci.org/ruby/ruby/jobs/523081688#L2679

Is this a Bundler issue?

@deivid-rodriguez
Copy link
Member

I think this should get fixed by rubygems/bundler#7062.

@bronzdoc
Copy link
Member

Just for the record, i just tested this with rubygems/bundler#7062 and the problem still persists.

@deivid-rodriguez
Copy link
Member

If it persists, it must persist in some other way because in the warnings mentioned, the overwrite_loaded_gem_version method appears in the backtrace, and that all has been removed in rubygems/bundler#7062.

@bronzdoc
Copy link
Member

This should be fixed now @MSP-Greg

@MSP-Greg
Copy link
Contributor Author

@bronzdoc

All good. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants