From fed953c09d8ce02cf34a0a9fac935bc37536a9c4 Mon Sep 17 00:00:00 2001 From: Benoit Daloze Date: Sun, 30 Aug 2020 16:00:53 +0200 Subject: [PATCH] Fix deprecation messages for `bundle install` flags, the config should be --local as before * See https://github.com/rubygems/rubygems/issues/3916 * Always show --local or --global for `bundle config set` commands as the default is global which can be not intuitive (#3916). --- bundler/CHANGELOG.md | 1 + bundler/UPGRADING.md | 4 +- bundler/lib/bundler.rb | 2 +- bundler/lib/bundler/cli.rb | 14 +- bundler/lib/bundler/dsl.rb | 2 +- bundler/lib/bundler/fetcher.rb | 2 +- bundler/lib/bundler/lazy_specification.rb | 2 +- bundler/lib/bundler/rubygems_gem_installer.rb | 2 +- bundler/lib/bundler/source_list.rb | 2 +- bundler/man/bundle-config.1 | 24 +- bundler/man/bundle-config.1.txt | 285 +++++++++--------- bundler/man/bundle-config.ronn | 24 +- bundler/man/gemfile.5 | 4 +- bundler/man/gemfile.5.ronn | 4 +- bundler/man/gemfile.5.txt | 4 +- bundler/spec/bundler/source_list_spec.rb | 2 +- bundler/spec/commands/outdated_spec.rb | 4 +- bundler/spec/install/gemfile/platform_spec.rb | 2 +- .../spec/install/gems/compact_index_spec.rb | 4 +- .../spec/install/gems/dependency_api_spec.rb | 2 +- bundler/spec/other/major_deprecation_spec.rb | 8 +- 21 files changed, 200 insertions(+), 198 deletions(-) diff --git a/bundler/CHANGELOG.md b/bundler/CHANGELOG.md index b063905806b4..7b58e968d665 100644 --- a/bundler/CHANGELOG.md +++ b/bundler/CHANGELOG.md @@ -12,6 +12,7 @@ - Avoid autoloading `openssl` to try help with jruby load service issues [#3809](https://github.com/rubygems/rubygems/pull/3809) - Fix `rake release` pushing all local tags instead of only the release tag [#3785](https://github.com/rubygems/rubygems/pull/3785) - Fix `rake release` aborting when credentials file is missing, even if properly configured through XDG [#3783](https://github.com/rubygems/rubygems/pull/3783) + - Fix deprecation warnings for `bundle install` flags to use `bundle config set --local KEY VALUE` [#3917](https://github.com/rubygems/rubygems/pull/3917) # 2.2.0.rc.1 (July 2, 2020) diff --git a/bundler/UPGRADING.md b/bundler/UPGRADING.md index 16ee8d3e759e..efee3704ad23 100644 --- a/bundler/UPGRADING.md +++ b/bundler/UPGRADING.md @@ -9,7 +9,7 @@ look like. All these deprecations are printed by default in the Bundler 2.1 rele If you don't want to deal with deprecations right now and want to toggle them off, you can do it through configuration. Set the `BUNDLE_SILENCE_DEPRECATIONS` environment variable to "true", or configure it through `bundle config` either -globally through `bundle config set silence_deprecations true` command, or +globally through `bundle config set --global silence_deprecations true` command, or locally through `bundle config set --local silence_deprecations true`. From now on in this document we will assume that all three of these configuration options are available, but will only mention `bundle config set